From: Timur Tabi <b04825@freescale.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
ppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: warnings from drivers/tty/ehv_bytechan.c
Date: Fri, 24 Feb 2012 16:15:04 -0600 [thread overview]
Message-ID: <4F480BE8.9080606@freescale.com> (raw)
In-Reply-To: <20120224220623.GA29400@kroah.com>
gregkh@linuxfoundation.org wrote:
>> > That's the simplest approach, for use. The TTY portion of the driver can
>> > be used as a module. Is there any real value in loading a TTY driver as a
>> > module?
> Depends on the hardware it supports :)
>
>> > In this case, the console support for byte channels would not be
>> > available.
> Then it doesn't make sense, right?
I guess that's my question. Is there a real use case for having console
output go to the serial port, and TTY go to a byte channel? Even if you
wanted to do that, I supposed you don't need to load the byte channel
driver as a module to get that behavior.
Anyway, that's all academic. A more important question is: now that the
driver can't be compiled as a module, should I change module_init() to
something else (like device_initcall)?
Should I remove this line?
#include <linux/module.h>
--
Timur Tabi
Linux kernel developer at Freescale
next prev parent reply other threads:[~2012-02-24 22:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 20:23 warnings from drivers/tty/ehv_bytechan.c Stephen Rothwell
2012-02-20 13:24 ` Tabi Timur-B04825
2012-02-24 21:50 ` gregkh
2012-02-24 22:00 ` Timur Tabi
2012-02-24 22:06 ` gregkh
2012-02-24 22:15 ` Timur Tabi [this message]
2012-02-24 22:19 ` gregkh
2012-02-24 23:25 ` Scott Wood
-- strict thread matches above, loose matches on Subject: below --
2012-02-19 20:07 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F480BE8.9080606@freescale.com \
--to=b04825@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.