From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33198)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S141L-00039y-9I
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 17:53:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S141K-0003E3-5q
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 17:53:47 -0500
Received: from cantor2.suse.de ([195.135.220.15]:35239 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S141K-0003DS-01
	for qemu-devel@nongnu.org; Fri, 24 Feb 2012 17:53:46 -0500
Message-ID: <4F4814F7.6040008@suse.de>
Date: Fri, 24 Feb 2012 23:53:43 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1330121921-23462-1-git-send-email-meadori@codesourcery.com>
In-Reply-To: <1330121921-23462-1-git-send-email-meadori@codesourcery.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno
 values correctly
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Meador Inge <meadori@codesourcery.com>
Cc: qemu-devel@nongnu.org, paul@codesourcery.com

Am 24.02.2012 23:18, schrieb Meador Inge:
> Fixing a simple typo, s/errno/err/, that caused
> the error status from GDB semihosted system calls
> to be returned incorrectly.
>=20
> Signed-off-by: Meador Inge <meadori@codesourcery.com>

Nice catch!

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

> ---
>  m68k-semi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/m68k-semi.c b/m68k-semi.c
> index bab01ee..6d60ced 100644
> --- a/m68k-semi.c
> +++ b/m68k-semi.c
> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulon=
g ret, target_ulong err)
>      }
>      /* FIXME - handle put_user() failure */
>      put_user_u32(ret, args);
> -    put_user_u32(errno, args + 4);
> +    put_user_u32(err, args + 4);
>  }
> =20
>  #define ARG(n)					\

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg