From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S14B9-0005H7-Cc for mharc-grub-devel@gnu.org; Fri, 24 Feb 2012 18:03:55 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44475) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S14B4-0005DG-FU for grub-devel@gnu.org; Fri, 24 Feb 2012 18:03:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S14B2-0004iF-Sx for grub-devel@gnu.org; Fri, 24 Feb 2012 18:03:50 -0500 Received: from mail-ee0-f41.google.com ([74.125.83.41]:49232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S14B2-0004fs-I5 for grub-devel@gnu.org; Fri, 24 Feb 2012 18:03:48 -0500 Received: by eeke53 with SMTP id e53so788725eek.0 for ; Fri, 24 Feb 2012 15:03:47 -0800 (PST) Received-SPF: pass (google.com: domain of phcoder@gmail.com designates 10.14.186.134 as permitted sender) client-ip=10.14.186.134; Authentication-Results: mr.google.com; spf=pass (google.com: domain of phcoder@gmail.com designates 10.14.186.134 as permitted sender) smtp.mail=phcoder@gmail.com; dkim=pass header.i=phcoder@gmail.com Received: from mr.google.com ([10.14.186.134]) by 10.14.186.134 with SMTP id w6mr2517047eem.96.1330124627567 (num_hops = 1); Fri, 24 Feb 2012 15:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=VfD20HHdot1/54kRsMVQuKrJpFtGgngI3u7+4kwt1hc=; b=xTpzKj2wcbE7zoJX+5kd3qFkjUeZsYImgtr4Y2CodzuKS2cSbTJln4ly03pmNUtlnw PcUNYK1IxuU88pCDUbZIw+jvkntNuZjb1T5cTD3jYasvcdzkVTo8x0rSIyR48zx1Xgl4 Z5ISLRkwHRktQhWZrR4Ds6tqjUnDqkJ3IVraQ= Received: by 10.14.186.134 with SMTP id w6mr1871459eem.96.1330124627415; Fri, 24 Feb 2012 15:03:47 -0800 (PST) Received: from debian.x201.phnet (107-233.197-178.cust.bluewin.ch. [178.197.233.107]) by mx.google.com with ESMTPS id u9sm23545211eem.11.2012.02.24.15.03.44 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 24 Feb 2012 15:03:46 -0800 (PST) Message-ID: <4F48174D.90800@gmail.com> Date: Sat, 25 Feb 2012 00:03:41 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: The submenu command shows a text-based menu when using a GFX theme. References: <1329961829.75149.YahooMailNeo@web113502.mail.gq1.yahoo.com> <4F45CD9F.7020408@gmail.com> <1330046651.95459.YahooMailNeo@web113503.mail.gq1.yahoo.com> <4F473FE2.7050301@gmail.com> <1330123849.11966.YahooMailNeo@web113501.mail.gq1.yahoo.com> In-Reply-To: <1330123849.11966.YahooMailNeo@web113501.mail.gq1.yahoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.83.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2012 23:03:51 -0000 On 24.02.2012 23:50, Towheed Mohammed wrote: > submenu "xyz" { > theme=... > } > > So we can say it's a feature. Well then, could it be patched thus: > > 1. If the user specifies a new theme for the submenu, load the new theme. The flicker is then not apparent as the new theme is loaded. > > 2. If the user wishes to use the currently loaded theme for the submenu, then simply load the menuentry items of the submenu without reloading the theme. > > This way, the screen flicker becomes non-existent/non-apparent. We already reuse the loaded menu if the theme file hasn't changed. > In either case though, the terminal-window should never be seen when descending into the submenu as it is now. The terminal-window should only be shown when a menuentry item is selected or the user wishes to edit the commands or drop to the command-line. terminal appears because of a message "Booting ...". Move it into some kind of status message is more long-term. Definitely post-2.0 > Thank you > Towheed Mohammed > > ----- Original Message ----- > From: Vladimir 'φ-coder/phcoder' Serbinenko > To: The development of GNU GRUB > Cc: > Sent: Friday, February 24, 2012 3:44 AM > Subject: Re: The submenu command shows a text-based menu when using a GFX theme. > > On 24.02.2012 02:24, Towheed Mohammed wrote: >> While 'export theme' fixes the issue more elegantly than what I had, it still results in the theme reloading when the submenu menuentry is selected. Reloading of the theme results in a screen flicker as the terminal window is shown before the theme reloads. >> >> I cannot code in C nor do I profess to be anywhere close to scripting as you guys, but I think a better solution to fixing the submenu issue would be from source code. >> >> Is it at all possible to simply load the menuentry items under the submenu command without having to reload the entire theme? If it can be done, wouldn't it prevent the flicker seen as the theme reloads? > Problem is that it's possible to do something like: > submenu "xyz" { > theme=... > } > And thus change the theme for submenu. >> While at it, could you also please fix the keyboard lag that results when a gfx theme is used. This is an issue with many users of gfx themes . >> >> Thank you. >> >> Towheed Mohammed >> >> ----- Original Message ----- >> From: Vladimir 'φ-coder/phcoder' Serbinenko >> To: grub-devel@gnu.org >> Cc: >> Sent: Thursday, February 23, 2012 1:24 AM >> Subject: Re: The submenu command shows a text-based menu when using a GFX theme. >> >> On 23.02.2012 02:50, Towheed Mohammed wrote: >>> If a gfx theme is being used and the submenu command is used to show a submenu, the submenu does not use the gfx theme. Instead a text-based menu is shown. The only way a regular user can workaround this at the moment is to reload the theme after the submenu menuentry item is selected. >>> >>> In Ubuntu's (about the only distro that uses the submenu command at this time) use of the submenu in 10_linux: >>> >>> if [ "$list" ]&& ! $in_submenu; then >>> in_submenu=: >>> fi >>> >>> A regular user must patch 10_linux thus: >>> >>> if [ "$list" ]&& ! $in_submenu; then >>> echo "submenu \"Previous Linux versions\" --class submenu {" >>> if [ "x$GRUB_THEME" != x ]&& [ -f "$GRUB_THEME" ] \ >>> && is_path_readable_by_grub "$GRUB_THEME"; then >>> prepare_grub_to_access_device `${grub_probe} --target=device "$GRUB_THEME"` >>> cat<< EOF >>> set theme=(\$root)`make_system_path_relative_to_its_root $GRUB_THEME` >>> EOF >>> fi >>> in_submenu=: >>> fi >> What a perfect example of overengineering just to compensate for missing >> "export theme". I've fixed it in trunk >>> to reload the theme and have a themed submenu. >>> >>> Will this be fixed in the 2.00 release? >>> >>> >>> _______________________________________________ >>> Grub-devel mailing list >>> Grub-devel@gnu.org >>> https://lists.gnu.org/mailman/listinfo/grub-devel >>> > -- Regards Vladimir 'φ-coder/phcoder' Serbinenko