From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1KNI-0007MF-U9 for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:21:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1KNB-0003GR-Ss for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:21:32 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1KNB-0003GN-NA for qemu-devel@nongnu.org; Sat, 25 Feb 2012 11:21:25 -0500 Message-ID: <4F490A84.2020700@weilnetz.de> Date: Sat, 25 Feb 2012 17:21:24 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1329695104-15174-1-git-send-email-aliguori@us.ibm.com> <1329695104-15174-4-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1329695104-15174-4-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/6] gtk: add virtual console support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Am 20.02.2012 00:45, schrieb Anthony Liguori: > This enables VteTerminal to be used to render the text consoles. > VteTerminal is > the same widget used by gnome-terminal which means it's VT100 > emulation is as > good as they come. > > It's also screen reader accessible, supports copy/paste, proper > scrolling and > most of the other features you would expect from a terminal widget. > > Signed-off-by: Anthony Liguori > --- > ui/gtk.c | 138 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 138 insertions(+), 0 deletions(-) > > diff --git a/ui/gtk.c b/ui/gtk.c > index 502705b..bf65a4f 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c [...] > +static int gd_vc_handler(QemuOpts *opts, CharDriverState **chrp) > +{ > + CharDriverState *chr; > + > + chr = g_malloc0(sizeof(*chr)); Some time ago, there was a decision to prefer g_new / g_new0: chr = g_new0(CharDriverState, 1); In function gtk_display_init there is also a g_malloc0 which should be replaced by g_new0. Regards, Stefan Weil