From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1O8o-0002Ua-NW for qemu-devel@nongnu.org; Sat, 25 Feb 2012 15:22:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1O8i-000456-Kg for qemu-devel@nongnu.org; Sat, 25 Feb 2012 15:22:50 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:39561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1O8i-00044u-EU for qemu-devel@nongnu.org; Sat, 25 Feb 2012 15:22:44 -0500 Message-ID: <4F494311.4010909@weilnetz.de> Date: Sat, 25 Feb 2012 21:22:41 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1329695104-15174-1-git-send-email-aliguori@us.ibm.com> <1329695104-15174-4-git-send-email-aliguori@us.ibm.com> <4F490A84.2020700@weilnetz.de> <4F493B43.8070304@codemonkey.ws> In-Reply-To: <4F493B43.8070304@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/6] gtk: add virtual console support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Am 25.02.2012 20:49, schrieb Anthony Liguori: > On 02/25/2012 10:21 AM, Stefan Weil wrote: >> Am 20.02.2012 00:45, schrieb Anthony Liguori: >>> This enables VteTerminal to be used to render the text consoles. >>> VteTerminal is >>> the same widget used by gnome-terminal which means it's VT100 >>> emulation is as >>> good as they come. >>> >>> It's also screen reader accessible, supports copy/paste, proper >>> scrolling and >>> most of the other features you would expect from a terminal widget. >>> >>> Signed-off-by: Anthony Liguori >>> --- >>> ui/gtk.c | 138 >>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 files changed, 138 insertions(+), 0 deletions(-) >>> >>> diff --git a/ui/gtk.c b/ui/gtk.c >>> index 502705b..bf65a4f 100644 >>> --- a/ui/gtk.c >>> +++ b/ui/gtk.c >> [...] >>> +static int gd_vc_handler(QemuOpts *opts, CharDriverState **chrp) >>> +{ >>> + CharDriverState *chr; >>> + >>> + chr = g_malloc0(sizeof(*chr)); >> >> Some time ago, there was a decision to prefer g_new / g_new0: > > I'm not sure where the book of decisions is kept, but I certainly > don't agree. a = malloc(sizeof(*a)) is an incredibly common pattern in > QEMU. > > It would be silly to change this pattern without good cause. > > Regards, > > Anthony Liguori Hi Anthony, there is no book of decisions for QEMU, but there is best practice. As far as I remember this topic was first discussed in this qemu-devel thread: http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg01988.html a = malloc(sizeof(*a)) is no longer a valid pattern for QEMU since you introduced glib-2.0. Those calls were converted to a = g_malloc(sizeof(*a)) which was reasonable for a simple automated code conversion. I also used the g_malloc pattern in my patch, but was convinced that glib-2.0 offers a better alternative using g_new. Kind regards, Stefan Weil