From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58476)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S1P3G-0004Au-9c
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 16:21:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S1P38-0003Hw-UL
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 16:21:10 -0500
Received: from cantor2.suse.de ([195.135.220.15]:49974 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S1P38-0003Hq-LT
	for qemu-devel@nongnu.org; Sat, 25 Feb 2012 16:21:02 -0500
Message-ID: <4F4950BC.2060102@suse.de>
Date: Sat, 25 Feb 2012 22:21:00 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1330198969-27364-1-git-send-email-aliguori@us.ibm.com>	<1330198969-27364-3-git-send-email-aliguori@us.ibm.com>
	<jibfnp$s95$1@dough.gmane.org> <4F494EC7.6070905@codemonkey.ws>
In-Reply-To: <4F494EC7.6070905@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 02/10] qtest: add support for -M pc
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Am 25.02.2012 22:12, schrieb Anthony Liguori:
> On 02/25/2012 02:19 PM, Paolo Bonzini wrote:
>> On 02/25/2012 08:42 PM, Anthony Liguori wrote:
>>> This involves replacing the local APIC with the qtest interrupt
>>> controller.
>>>
>>> It should be pretty straight forward to do the same for other machine
>>> types.
>>>
>>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>>> ---
>>>   hw/pc_piix.c |    3 +++
>>>   1 files changed, 3 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>>> index 5e11d15..2c0881e 100644
>>> --- a/hw/pc_piix.c
>>> +++ b/hw/pc_piix.c
>>> @@ -46,6 +46,7 @@
>>>   #ifdef CONFIG_XEN
>>>   #  include<xen/hvm/hvm_info_table.h>
>>>   #endif
>>> +#include "qtest.h"
>>>
>>>   #define MAX_IDE_BUS 2
>>>
>>> @@ -212,6 +213,8 @@ static void pc_init1(MemoryRegion *system_memory,
>>>           i8259 =3D kvm_i8259_init(isa_bus);
>>>       } else if (xen_enabled()) {
>>>           i8259 =3D xen_interrupt_controller_init();
>>> +    } else if (qtest_enabled()) {
>>> +        i8259 =3D qtest_interrupt_controller_init();
>>>       } else {
>>>           cpu_irq =3D pc_allocate_cpu_irq();
>>>           i8259 =3D i8259_init(isa_bus, cpu_irq[0]);
>>
>> This is not needed anymore.
>=20
> Why?  This is necessary for IRQ to work.
>=20
> You mean, if you use irq_intercept, this isn't needed?

The reason for Paolo's RFC was to _avoid_ having to touch every target
with code such as the above, no?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg