From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56164) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1SxR-0001Yo-5t for qemu-devel@nongnu.org; Sat, 25 Feb 2012 20:31:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1SxJ-0004RV-JS for qemu-devel@nongnu.org; Sat, 25 Feb 2012 20:31:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58922 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1SxJ-0004RI-DT for qemu-devel@nongnu.org; Sat, 25 Feb 2012 20:31:17 -0500 Message-ID: <4F498B63.3030202@suse.de> Date: Sun, 26 Feb 2012 02:31:15 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1330198969-27364-1-git-send-email-aliguori@us.ibm.com> <1330198969-27364-8-git-send-email-aliguori@us.ibm.com> <4F494F91.1000509@codemonkey.ws> In-Reply-To: <4F494F91.1000509@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 07/10] qtest: IRQ interception infrastructure (v2) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , qemu-devel@nongnu.org, Jan Kiszka Am 25.02.2012 22:16, schrieb Anthony Liguori: > On 02/25/2012 02:20 PM, Paolo Bonzini wrote: >> On 02/25/2012 08:42 PM, Anthony Liguori wrote: >>> + =20 >>> object_property_add_child(object_resolve_path("/i440fx/piix3", NULL), >>> + "ioapic", OBJECT(dev), NULL); >> >> Jan objected to putting this under /i440fx/piix3. >=20 > I think for our model, having it as a child property makes quite a lot > of sense. Weren't you discussing rearranging the tree so that devices are under a separate node from block devices etc. (e.g., /devices)? Would be a good idea to introduce a (dummy) object_resolve_device_path() to avoid having to change hardcoded absolute string paths like the above later. Or do that change first so that new paths like this one at least don't need to be touched again. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg