From: Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Hefty,
Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 2/6] IB/core: fix wrong display of rate in sysfs
Date: Sun, 26 Feb 2012 10:22:41 +0200 [thread overview]
Message-ID: <4F49EBD1.7030900@mellanox.com> (raw)
In-Reply-To: <CAJZOPZJHbuyfXbQdEQ3QZt3O+bLTdzpBJOfUmB-Rqrvi9WUXuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 1/11/2012 9:45 PM, Or Gerlitz wrote:
> Yep, this function is surely not programming state of the art..
> however, except for SDR, the above line doing rate = rate *
> ib_width_enum_to_int(attr.active_width) would hold for all the speeds
> and all the widths (1X, 4X, 12X), if we just set rate (possibly as a
> string value) one time in each switch case, we would need to repeat
> that multiplication there... I'm okay with that, would you recommend
> to go that way? Roland any preference? Or.
Hi Roland,
Could you please let me know if you want a change in this patch, or this
fix can go in using the current form for 3.4?
thanks,
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-02-26 8:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 16:52 [PATCH for-3.3 0/6] IB: set of fixes and additions Or Gerlitz
[not found] ` <alpine.LRH.2.00.1201111850330.10264-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2012-01-11 16:54 ` [PATCH 1/6] IB: use central enum for speed instead of hard-coded values Or Gerlitz
[not found] ` <alpine.LRH.2.00.1201111854190.10264-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2012-01-11 18:53 ` Hefty, Sean
2012-01-12 17:34 ` [PATCH V1 " Or Gerlitz
[not found] ` <alpine.LRH.2.00.1201121932160.5886-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2012-01-12 19:30 ` Roland Dreier
[not found] ` <CAG4TOxPPNuNYUjvt44mVq94Zpi6eN2tERq23ky7p37v2XLBZHw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-12 19:40 ` Or Gerlitz
2012-01-15 15:34 ` Or Gerlitz
2012-01-12 20:13 ` [PATCH V2 " Or Gerlitz
2012-02-28 16:49 ` [PATCH V3 " Or Gerlitz
2012-01-11 16:56 ` [PATCH 2/6] IB/core: fix wrong display of rate in sysfs Or Gerlitz
[not found] ` <alpine.LRH.2.00.1201111856160.10264-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2012-01-11 19:30 ` Hefty, Sean
[not found] ` <1828884A29C6694DAF28B7E6B8A82373256757DB-P5GAC/sN6hmkrb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2012-01-11 19:45 ` Or Gerlitz
[not found] ` <CAJZOPZJHbuyfXbQdEQ3QZt3O+bLTdzpBJOfUmB-Rqrvi9WUXuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-26 8:22 ` Or Gerlitz [this message]
[not found] ` <4F49EBD1.7030900-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-02-27 17:23 ` Roland Dreier
[not found] ` <CAL1RGDWNh1_fFWS=gMxo8vm-n46TOTxbu+GmRNE1YEmAyuE1Tw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-02-28 6:45 ` Or Gerlitz
2012-02-28 15:15 ` Or Gerlitz
2012-02-28 15:17 ` Or Gerlitz
2012-01-11 17:00 ` [PATCH 3/6] IB/mlx4: fix wrong info returned when querying IBoE ports Or Gerlitz
2012-01-11 17:02 ` [PATCH 4/6] net/mlx4: allow for dynamic mtu configuration for IB ports Or Gerlitz
2012-01-11 17:03 ` [PATCH 5/6] IB: change CQ TCP/IP checksum offload mark to use bit flag indication instead of integer Or Gerlitz
[not found] ` <alpine.LRH.2.00.1201111903140.10264-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2012-01-11 18:59 ` Hefty, Sean
2012-01-11 17:06 ` [PATCH 6/6] IB/ipoib: add support for clones / multiple childs on the same partition Or Gerlitz
[not found] ` <alpine.LRH.2.00.1201111905150.10264-VYr5/9ddeaGSIdy2EShu12Xnswh1EIUO@public.gmane.org>
2012-01-15 15:31 ` [PATCH] IB/ipoib: eliminate nested locking of the vlan mutex Or Gerlitz
2012-02-15 20:24 ` [PATCH for-3.3 0/6] IB: set of fixes and additions Or Gerlitz
2012-03-12 16:29 ` Or Gerlitz
[not found] ` <4F5E245F.3070303-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-03-12 16:35 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F49EBD1.7030900@mellanox.com \
--to=ogerlitz-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.