From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: integrator: convert to sparse irqs
Date: Sun, 26 Feb 2012 21:42:13 -0600 [thread overview]
Message-ID: <4F4AFB95.9040204@gmail.com> (raw)
In-Reply-To: <CACRpkdbjeAmD=AsybOEkYFMUEyvfwONawdDGtfwMhBhrKyg2hQ@mail.gmail.com>
On 02/26/2012 03:45 AM, Linus Walleij wrote:
> On Fri, Feb 24, 2012 at 8:15 PM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj@jcrosoft.com> wrote:
>> On 18:32 Fri 24 Feb , Linus Walleij wrote:
>
>>> -#define NR_IRQS 47
>>> +#define NR_IRQS_INTEGRATOR_AP 34
>>> +#define NR_IRQS_INTEGRATOR_CP 47
>>
>> why do you need to specified both?
>
> They are two totally different machines and should never have had that
> common roof of NR_IRQS = max(AP,CP), it's just not elegant.
>
> Maybe I'm a bit pedantic but I want to set the .nr_irqs for each machine so that
> it corresponds exactly to what it actually has, instead of using a roof value.
> I think it improves readability and understanding.
>
Really, you want to get rid of the value altogether. Each irq_chip
should allocate its irq_descs and then you don't need to set .nr_irqs.
Rob
> Yours
> Linus Walleij
next prev parent reply other threads:[~2012-02-27 3:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 17:32 [PATCH] ARM: integrator: convert to sparse irqs Linus Walleij
2012-02-24 19:04 ` Rob Herring
2012-02-24 19:15 ` Jean-Christophe PLAGNIOL-VILLARD
2012-02-26 9:45 ` Linus Walleij
2012-02-27 3:42 ` Rob Herring [this message]
2012-02-27 7:44 ` Linus Walleij
2012-02-27 14:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4AFB95.9040204@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.