From: "Andreas Färber" <afaerber@suse.de>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gerhard Wiesinger <lists@wiesinger.com>,
qemu-devel@nongnu.org, Hannes Reinecke <hare@suse.de>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation
Date: Mon, 27 Feb 2012 14:47:49 +0100 [thread overview]
Message-ID: <4F4B8985.2080308@suse.de> (raw)
In-Reply-To: <20120223153419.GA20732@redhat.com>
Am 23.02.2012 16:34, schrieb Michael S. Tsirkin:
> On Tue, Feb 21, 2012 at 10:36:43AM +0100, Hannes Reinecke wrote:
>> diff --git a/hw/megasas.c b/hw/megasas.c
>> new file mode 100644
>> index 0000000..083c3d3
>> --- /dev/null
>> +++ b/hw/megasas.c
>> +static void megaraid1078_register_types(void)
>> +{
>> + type_register_static(&megasas_info);
>> +}
>> +
>> +type_init(megaraid1078_register_types);
>
>
> why not megasas_ ?
And while at it, no semicolon after type_init() please. It defines a
function and I recently cleaned up all callers.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-02-27 13:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 9:36 [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation Hannes Reinecke
2012-02-21 18:54 ` Gerhard Wiesinger
2012-02-23 7:03 ` Gerhard Wiesinger
2012-02-23 7:14 ` Andreas Färber
2012-02-23 7:20 ` Gerhard Wiesinger
2012-02-23 7:12 ` Alexander Graf
2012-02-23 15:34 ` Michael S. Tsirkin
2012-02-24 15:58 ` Anthony Liguori
2012-02-24 16:05 ` Alexander Graf
2012-02-24 16:13 ` Anthony Liguori
2012-02-27 9:17 ` Hannes Reinecke
2012-02-27 10:31 ` Michael S. Tsirkin
2012-02-27 15:24 ` Hannes Reinecke
2012-03-02 7:20 ` Gerhard Wiesinger
2012-02-27 13:47 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4B8985.2080308@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=hare@suse.de \
--cc=lists@wiesinger.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.