From: Rik van Riel <riel@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Mel Gorman <mel@csn.ul.ie>,
Johannes Weiner <hannes@cmpxchg.org>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
hughd@google.com
Subject: Re: [PATCH -mm 2/2] mm: do not reset mm->free_area_cache on every single munmap
Date: Mon, 27 Feb 2012 11:13:46 -0500 [thread overview]
Message-ID: <4F4BABBA.9050207@redhat.com> (raw)
In-Reply-To: <m2vcmxp609.fsf@firstfloor.org>
On 02/23/2012 04:57 PM, Andi Kleen wrote:
> Rik van Riel<riel@redhat.com> writes:
>
>> Some programs have a large number of VMAs, and make frequent calls
>> to mmap and munmap. Having munmap constantly cause the search
>> pointer for get_unmapped_area to get reset can cause a significant
>> slowdown for such programs.
>
> This would be a much nicer patch if you split it into one that merges
> all the copy'n'paste code and another one that actually implements
> the new algorithm.
The copy'n'pasted functions are not quite the same, though.
All the ones that could be unified already have been, leaving
a few functions with actual differences around.
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, Mel Gorman <mel@csn.ul.ie>,
Johannes Weiner <hannes@cmpxchg.org>,
KOSAKI Motohiro <kosaki.motohiro@gmail.com>,
Andrea Arcangeli <aarcange@redhat.com>,
hughd@google.com
Subject: Re: [PATCH -mm 2/2] mm: do not reset mm->free_area_cache on every single munmap
Date: Mon, 27 Feb 2012 11:13:46 -0500 [thread overview]
Message-ID: <4F4BABBA.9050207@redhat.com> (raw)
In-Reply-To: <m2vcmxp609.fsf@firstfloor.org>
On 02/23/2012 04:57 PM, Andi Kleen wrote:
> Rik van Riel<riel@redhat.com> writes:
>
>> Some programs have a large number of VMAs, and make frequent calls
>> to mmap and munmap. Having munmap constantly cause the search
>> pointer for get_unmapped_area to get reset can cause a significant
>> slowdown for such programs.
>
> This would be a much nicer patch if you split it into one that merges
> all the copy'n'paste code and another one that actually implements
> the new algorithm.
The copy'n'pasted functions are not quite the same, though.
All the ones that could be unified already have been, leaving
a few functions with actual differences around.
--
All rights reversed
next prev parent reply other threads:[~2012-02-27 16:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 19:54 [PATCH -mm 0/2] speed up arch_get_unmapped_area Rik van Riel
2012-02-23 19:54 ` Rik van Riel
2012-02-23 19:56 ` [PATCH -mm 1/2] mm: fix quadratic behaviour in get_unmapped_area_topdown Rik van Riel
2012-02-23 19:56 ` Rik van Riel
2012-02-23 21:50 ` Andrew Morton
2012-02-23 21:50 ` Andrew Morton
2012-02-23 21:57 ` Johannes Weiner
2012-02-23 21:57 ` Johannes Weiner
2012-02-23 20:00 ` [PATCH -mm 2/2] mm: do not reset mm->free_area_cache on every single munmap Rik van Riel
2012-02-23 20:00 ` Rik van Riel
2012-02-23 21:56 ` Andrew Morton
2012-02-23 21:56 ` Andrew Morton
2012-02-27 16:12 ` Rik van Riel
2012-02-27 16:12 ` Rik van Riel
2012-03-20 18:32 ` Rik van Riel
2012-03-20 18:32 ` Rik van Riel
2012-03-20 19:00 ` Andrea Arcangeli
2012-03-20 19:00 ` Andrea Arcangeli
2012-03-20 19:06 ` Rik van Riel
2012-03-20 19:06 ` Rik van Riel
2012-02-23 21:57 ` Andi Kleen
2012-02-23 21:57 ` Andi Kleen
2012-02-27 16:13 ` Rik van Riel [this message]
2012-02-27 16:13 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4BABBA.9050207@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.