From mboxrd@z Thu Jan 1 00:00:00 1970 From: John David Anglin Subject: Re: [PATCH] parisc: dont unconditionally override CROSS_COMPILE for 64 bit. Date: Mon, 27 Feb 2012 11:45:09 -0500 Message-ID: <4F4BB315.6060501@bell.net> References: <1330298813-17262-1-git-send-email-paul.gortmaker@windriver.com> <4F4B9DD2.6000600@bell.net> <4F4BAF16.9060507@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail16.primus.ca ([216.254.141.183]:59456 "EHLO mail-02.primus.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753654Ab2B0Qoy (ORCPT ); Mon, 27 Feb 2012 11:44:54 -0500 In-Reply-To: <4F4BAF16.9060507@windriver.com> Sender: linux-next-owner@vger.kernel.org List-ID: To: Paul Gortmaker Cc: JBottomley@parallels.com, jejb@parisc-linux.org, kyle@mcmartin.ca, deller@gmx.de, linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org On 2/27/2012 11:28 AM, Paul Gortmaker wrote: > On 12-02-27 10:14 AM, John David Anglin wrote: >> > On 2/26/2012 6:26 PM, Paul Gortmaker wrote: >>> >> Using the 64 bit toolchains from kernel.org[1], one finds that >>> >> you can't build the a500_defconfig, because the Makefile will >>> >> stomp whatever value you have in your env. for CROSS_COMPILE. >>> >> >>> >> This shows up since the kernel.org toolchains for parisc-64 >>> >> do not have the "-gnu" prefix, and so you run into it always >>> >> saying hppa64-linux-gnu-gcc not found, regardless of the fact >>> >> you've not got "-gnu" put anywhere into CROSS_COMPILE. >>> >> >>> >> [1]ftp://ftp.kernel.org/pub/tools/crosstool/files/bin/x86_64/4.5.2/ >>> >> >>> >> Signed-off-by: Paul Gortmaker >>> >> >>> >> diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile >>> >> index 55cca1d..cefff6d 100644 >>> >> --- a/arch/parisc/Makefile >>> >> +++ b/arch/parisc/Makefile >>> >> @@ -31,7 +31,9 @@ ifdef CONFIG_64BIT >>> >> UTS_MACHINE := parisc64 >>> >> CHECKFLAGS += -D__LP64__=1 -m64 >>> >> WIDTH := 64 >>> >> -CROSS_COMPILE := hppa64-linux-gnu- >>> >> +ifndef CROSS_COMPILE >>> >> + CROSS_COMPILE := hppa64-linux-gnu- >>> >> +endif >>> >> else # 32-bit >>> >> WIDTH := >>> >> endif >> > This change breaks native builds. So, I assume CROSS_COMPILE must be >> > previously defined. > You lost me here. As in a native 32bit env. doing a build for the > 64 bit case is setting CROSS_COMPILE? > Yes, native hppa is 32 bit . Building a 64-bit kernel with CONFIG_64BIT causes the setting of CROSS_COMPILE and the selection of hppa64-linux-gnu-gcc, etc. If CROSS_COMPILE wasn't previously defined, your change wouldn't have have affected the 64-bit build. Dave -- John David Anglin dave.anglin@bell.net