All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Chilam Ng <chilamng@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>, <ath6kl-devel@qualcomm.com>
Subject: Re: [PATCH] ath6kl: assign Tx packet drop threshold per endpoint based on AC priority
Date: Mon, 27 Feb 2012 19:17:40 +0200	[thread overview]
Message-ID: <4F4BBAB4.90000@qca.qualcomm.com> (raw)
In-Reply-To: <1328782621-5251-1-git-send-email-chilamng@qca.qualcomm.com>

On 02/09/2012 12:17 PM, Chilam Ng wrote:
> Tx packets will begin to drop when there are multiple traffic priorities
> and the current traffic is not the highest priority and the remaining
> cookies drop below a certain number, which is fixed for all AC. It is
> possilbe that lower priority AC have more traffic which will consume
> more cookies and lock out higher priority AC from having any. Assign
> each endpoint (AC) with a different Tx-packet-drop threshold so lower
> priority AC is more likely to drop packets and the cookies become more
> available to higher priority AC.
> 
> Signed-off-by: Chilam Ng <chilamng@qca.qualcomm.com>

Thanks, applied. The real fix of course is to implement multiqueue
support in ath6kl and get rid of the cookie stuff completely. But this
is a good quick fix.

Kalle

      reply	other threads:[~2012-02-27 17:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-09 10:17 [PATCH] ath6kl: assign Tx packet drop threshold per endpoint based on AC priority Chilam Ng
2012-02-27 17:17 ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F4BBAB4.90000@qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath6kl-devel@qualcomm.com \
    --cc=chilamng@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.