From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S259E-00065p-01 for mharc-grub-devel@gnu.org; Mon, 27 Feb 2012 13:18:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2599-00065O-1E for grub-devel@gnu.org; Mon, 27 Feb 2012 13:18:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2597-0006Fv-J5 for grub-devel@gnu.org; Mon, 27 Feb 2012 13:18:02 -0500 Received: from mail-ee0-f41.google.com ([74.125.83.41]:56419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2597-0006Fq-Cv for grub-devel@gnu.org; Mon, 27 Feb 2012 13:18:01 -0500 Received: by eeke53 with SMTP id e53so1814660eek.0 for ; Mon, 27 Feb 2012 10:18:00 -0800 (PST) Received-SPF: pass (google.com: domain of phcoder@gmail.com designates 10.14.100.80 as permitted sender) client-ip=10.14.100.80; Authentication-Results: mr.google.com; spf=pass (google.com: domain of phcoder@gmail.com designates 10.14.100.80 as permitted sender) smtp.mail=phcoder@gmail.com; dkim=pass header.i=phcoder@gmail.com Received: from mr.google.com ([10.14.100.80]) by 10.14.100.80 with SMTP id y56mr8874035eef.68.1330366680390 (num_hops = 1); Mon, 27 Feb 2012 10:18:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Y6G6PNO1y8eGKXjZAjxkBmtNyxDleqkbEmSOWWwcrq8=; b=lDod7Oo426WVRsBI6E5q+PmHwFnUGQMq7g3h3djEcndpV4uxx0FTDOlTpju7mnGwfo xENRUM/DjK1oB8NJmQcpbW6k67WbnwD/uZ6RIxjz1DpoYVztTKdfaz200FaFTv5g7xPU TzJSVsjRQK934kVFr2efgVeSNwL5j8ostCJXI= Received: by 10.14.100.80 with SMTP id y56mr6681294eef.68.1330366680316; Mon, 27 Feb 2012 10:18:00 -0800 (PST) Received: from debian.x201.phnet (19-234.197-178.cust.bluewin.ch. [178.197.234.19]) by mx.google.com with ESMTPS id u9sm60497750eem.11.2012.02.27.10.17.56 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 27 Feb 2012 10:17:58 -0800 (PST) Message-ID: <4F4BC8C1.3080805@gmail.com> Date: Mon, 27 Feb 2012 19:17:37 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: Richard Laager Subject: Re: Freeze on 27 February References: <4F43C25C.2040106@gmail.com> <1329888906.16648.134.camel@watermelon.coderich.net> <4F45DDF0.2090908@gmail.com> <1330325907.2901.28.camel@watermelon.coderich.net> In-Reply-To: <1330325907.2901.28.camel@watermelon.coderich.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.83.41 Cc: The development of GRUB 2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2012 18:18:07 -0000 On 27.02.2012 07:58, Richard Laager wrote: > On Thu, 2012-02-23 at 07:34 +0100, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >>> zfs-poolname-spaces.patch >> ... >>> @@ -420,6 +419,9 @@ >>> if (sscanf (sep, "%s %s", entry.fstype, entry.device) != 2) >>> continue; >>> >>> + unescape (entry.fstype); >>> + unescape (entry.device); >>> + >> You need to increase the size of storage for these fields. > On second look... why? It turns out that the sizes were already increased. Just that PATH_MAX refers to unescaped length, original can be substantially larger. > The unescape() function modifies the string in > place, and it changes multi-character escape sequences into single > unescaped characters. I don't understand how this would change the size > requirement. > -- Regards Vladimir 'φ-coder/phcoder' Serbinenko