From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S25Bc-0006gd-Eh for mharc-grub-devel@gnu.org; Mon, 27 Feb 2012 13:20:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51427) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S25Ba-0006fk-HM for grub-devel@gnu.org; Mon, 27 Feb 2012 13:20:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S25BT-0006nm-PT for grub-devel@gnu.org; Mon, 27 Feb 2012 13:20:34 -0500 Received: from mail-ee0-f41.google.com ([74.125.83.41]:59851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S25BT-0006nh-HY for grub-devel@gnu.org; Mon, 27 Feb 2012 13:20:27 -0500 Received: by eeke53 with SMTP id e53so1815491eek.0 for ; Mon, 27 Feb 2012 10:20:26 -0800 (PST) Received-SPF: pass (google.com: domain of phcoder@gmail.com designates 10.213.19.207 as permitted sender) client-ip=10.213.19.207; Authentication-Results: mr.google.com; spf=pass (google.com: domain of phcoder@gmail.com designates 10.213.19.207 as permitted sender) smtp.mail=phcoder@gmail.com; dkim=pass header.i=phcoder@gmail.com Received: from mr.google.com ([10.213.19.207]) by 10.213.19.207 with SMTP id c15mr2525271ebb.67.1330366826716 (num_hops = 1); Mon, 27 Feb 2012 10:20:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=+exkaPeq/nZDlpxJR8lxvf7AHLPiz8iABgDTcmuadCs=; b=eDe6qADT7JaoYEDUlPTYXYc0Jn2E9uZd92Sy4aP55S9EpJQbSwnh8uv31J3saPnMBs ESaiY3IgEaddDOeN81BB6qoSA5B1rqF348MGbxC2xfvZ5lZIROjy3XYyuUJzcDQuhV4v Bc7TXjZzf+5yVNN+t2ArrsaBSgxxAcnsA3vMg= Received: by 10.213.19.207 with SMTP id c15mr1893247ebb.67.1330366826650; Mon, 27 Feb 2012 10:20:26 -0800 (PST) Received: from debian.x201.phnet (19-234.197-178.cust.bluewin.ch. [178.197.234.19]) by mx.google.com with ESMTPS id y14sm60519464eef.10.2012.02.27.10.20.22 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 27 Feb 2012 10:20:25 -0800 (PST) Message-ID: <4F4BC95C.5040706@gmail.com> Date: Mon, 27 Feb 2012 19:20:12 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: Richard Laager , The development of GRUB 2 Subject: Re: Freeze on 27 February References: <4F43C25C.2040106@gmail.com> <1329888906.16648.134.camel@watermelon.coderich.net> <4F45DDF0.2090908@gmail.com> <1330033617.3895.26.camel@watermelon.coderich.net> <4F4AC782.1090402@gmail.com> <1330322499.2901.5.camel@watermelon.coderich.net> In-Reply-To: <1330322499.2901.5.camel@watermelon.coderich.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.83.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2012 18:20:35 -0000 On 27.02.2012 07:01, Richard Laager wrote: > On Mon, 2012-02-27 at 01:00 +0100, Vladimir 'φ-coder/phcoder' Serbinenko > wrote: >>> The allowed characters are: [a-zA-Z0-9_.: -] >> This isn't a good enough argument. One could purposedly create a pool >> named `rm -rf /*` even though it's incorrect. > By "allowed characters", I meant that the normal ZFS stack will not > permit you to create a pool using characters outside that range. That > said, I haven't verified that the kernel itself refuses to create/load > such a pool. I've rewritten this code. I've also committed most of your changes except the one adding the tree scanning when we already have one > > The patch I proposed is no worse than the code that's already in GRUB. > Given the impending freeze and the fact that I'm on vacation, can you > apply it and I'll come back to this issue later? I've CC'ed myself so I > don't forget. > -- Regards Vladimir 'φ-coder/phcoder' Serbinenko