From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zach Brown <zab@zabbo.net>
Subject: Re: [RFC PATCH 13/22] dio: add __blockdev_direct_IO_bdev()
Date: Mon, 27 Feb 2012 17:16:57 -0500
Message-ID: <4F4C00D9.6090706@zabbo.net>
References: <1330377576-3659-1-git-send-email-dave.kleikamp@oracle.com> <1330377576-3659-14-git-send-email-dave.kleikamp@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Dave Kleikamp <dave.kleikamp@oracle.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from lulu.zabbo.net ([69.168.54.52]:54697 "EHLO lulu.zabbo.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754629Ab2B0WQ7 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 27 Feb 2012 17:16:59 -0500
In-Reply-To: <1330377576-3659-14-git-send-email-dave.kleikamp@oracle.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>


>   	int is_async;			/* is IO async ? */
> +	int should_dirty;		/* should we mark read pages dirty? */

This seems wasteful.  Maybe its time for some bit flags?

- z