From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] SPEAr: Configure FSMC driver for NAND interface
Date: Mon, 27 Feb 2012 16:32:22 -0600 [thread overview]
Message-ID: <4F4C0476.3000706@freescale.com> (raw)
In-Reply-To: <201202271102.18797.sr@denx.de>
On 02/27/2012 04:02 AM, Stefan Roese wrote:
>> diff --git a/include/configs/spear-common.h
>> b/include/configs/spear-common.h index 516b78e..c37305f 100644
>> --- a/include/configs/spear-common.h
>> +++ b/include/configs/spear-common.h
>> @@ -90,7 +90,7 @@
>> /* NAND FLASH Configuration */
>> #define CONFIG_MTD_DEVICE
>> #define CONFIG_MTD_PARTITIONS
>> -#define CONFIG_NAND_SPEAR 1
>> +#define CONFIG_NAND_FSMC
>> #define CONFIG_SYS_MAX_NAND_DEVICE 1
>> #define CONFIG_MTD_NAND_VERIFY_WRITE
>
> I suggest that you remove this last define. Most likely it was added for
> debugging purpose only. It slows down the speed and it brakes UBI support.
What is the problem with UBI?
>> +/* NAND flash configuration */
>> +#define CONFIG_SYS_FSMC_NAND_SP
>> +#define CONFIG_SYS_FSMC_NAND_8BIT
>
> You also need the following define for this to work with the latest NAND
> subsystem:
>
> #define CONFIG_MTD_ECC_SOFT
>
> Not sure about SPEAr3xx. Most likely this needs it as well.
This is going to be reverted for now -- I meant to leave it out of the
last patchset because of the need to update all boards (which the patch
did not do).
-Scott
next prev parent reply other threads:[~2012-02-27 22:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 9:38 [U-Boot] [PATCH 0/3] mtd/NAND: Support for FSMC controller Amit Virdi
2012-02-27 9:38 ` [U-Boot] [PATCH 1/3] mtd/NAND: Add FSMC driver support Amit Virdi
2012-03-01 21:27 ` Scott Wood
2012-03-02 11:16 ` Amit Virdi
2012-03-05 23:39 ` Scott Wood
2012-02-27 9:38 ` [U-Boot] [PATCH 2/3] SPEAr: Configure FSMC driver for NAND interface Amit Virdi
2012-02-27 10:02 ` Stefan Roese
2012-02-27 10:15 ` Amit Virdi
2012-02-27 22:32 ` Scott Wood [this message]
2012-02-29 10:11 ` Amit Virdi
2012-02-29 18:03 ` Scott Wood
2012-03-02 11:24 ` Amit Virdi
2012-03-02 13:44 ` Stefan Roese
2012-03-02 17:19 ` Scott Wood
2012-02-29 10:09 ` Amit Virdi
2012-02-27 9:38 ` [U-Boot] [PATCH 3/3] mtd/NAND: Remove obsolete SPEAr specific NAND drivers Amit Virdi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4C0476.3000706@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.