From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2DVC-0006PP-PD for qemu-devel@nongnu.org; Mon, 27 Feb 2012 22:13:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2DV3-0007kt-KQ for qemu-devel@nongnu.org; Mon, 27 Feb 2012 22:13:22 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:64581) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2DV3-0007jW-Fl for qemu-devel@nongnu.org; Mon, 27 Feb 2012 22:13:13 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=UTF-8; format=flowed Received: from euspt1 ([210.118.77.13]) by mailout3.w1.samsung.com (Sun Java(tm) System Messaging Server 6.3-8.04 (built Jul 29 2009; 32bit)) with ESMTP id <0M0300JPZ29XF530@mailout3.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 28 Feb 2012 03:13:09 +0000 (GMT) Received: from [106.109.9.191] by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M03000NH29WQS@spt1.w1.samsung.com> for qemu-devel@nongnu.org; Tue, 28 Feb 2012 03:13:09 +0000 (GMT) Date: Tue, 28 Feb 2012 07:13:07 +0400 From: Evgeny Voevodin In-reply-to: Message-id: <4F4C4643.2080007@samsung.com> References: <1330340818-4125-1-git-send-email-e.voevodin@samsung.com> <1330344787-14482-1-git-send-email-e.voevodin@samsung.com> Subject: Re: [Qemu-devel] [PATCH v2] TCG: Convert global variables to be TLS. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: kyungmin.park@samsung.com, m.kozlov@samsung.com, i.mitsyanko@samsung.com, qemu-devel@nongnu.org, d.solodkiy@samsung.com On 27.02.2012 16:35, Peter Maydell wrote: > On 27 February 2012 12:13, Evgeny Voevodin wrote: >> This commit converts code_gen_buffer, code_gen_ptr, tbs, nb_tbs to >> TLS. We need this if we want TCG to become multithreaded. > I'm sceptical about doing this kind of thing as a change on its > own. A true multithreaded TCG is a large project, and unless we're > going to commit to doing that I don't see much value in making > some variables per-thread when we might instead need to do > larger refactorings (properly encapsulating the codegen > caches as qom objects, maybe?). > > -- PMM > I wanted to get some feedback and points to show up a direction to move in this field. And qomification of translation caches is an interesting suggestion I think. -- Kind regards, Evgeny Voevodin, Leading Software Engineer, ASWG, Moscow R&D center, Samsung Electronics e-mail: e.voevodin@samsung.com