From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50955)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S2JbZ-00046i-63
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 04:44:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S2JbS-0005nA-F3
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 04:44:20 -0500
Received: from plane.gmane.org ([80.91.229.3]:51297)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S2JbS-0005mo-8V
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 04:44:14 -0500
Received: from list by plane.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1S2JbQ-0000Cq-Ib
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 10:44:12 +0100
Received: from 213.33.220.118 ([213.33.220.118])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Tue, 28 Feb 2012 10:44:12 +0100
Received: from i.mitsyanko by 213.33.220.118 with local (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Tue, 28 Feb 2012 10:44:12 +0100
From: Igor Mitsyanko <i.mitsyanko@samsung.com>
Date: Tue, 28 Feb 2012 13:43:57 +0400
Message-ID: <4F4CA1DD.6080905@samsung.com>
References: <1330413510-9289-1-git-send-email-i.mitsyanko@samsung.com>
	<jii3sl$lo4$1@dough.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <jii3sl$lo4$1@dough.gmane.org>
Subject: Re: [Qemu-devel] [PATCH] qom: if @instance_size==0,
 assign size of object to parent object size
Reply-To: i.mitsyanko@samsung.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On 02/28/2012 12:39 PM, Paolo Bonzini wrote:
> Il 28/02/2012 08:18, Igor Mitsyanko ha scritto:
>> QOM documentation states that for objects of type with @instance_size == 0 size
>> will be assigned to match parent object's size. But currently this feauture is
>> not implemented and qemu asserts during creation of object with zero instance_size.
>> This patch adjusts actual behaviour in accordance with documentation.
>
> You can do it just once, in type_get_parent instead.
>
> Paolo
>
>
>
Can't understand how type_get_parent() is relevant to this, we can call 
object_initialize() or object_new_with_type() and these two functions 
must set instance_size before calling object_initialize_with_type(). Up 
to this point there are no calls to type_get_parent().

Mitsyanko Igor
ASWG, Moscow R&D center, Samsung Electronics
email: i.mitsyanko@samsung.com