From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions
Date: Tue, 28 Feb 2012 10:47:45 +0100 [thread overview]
Message-ID: <4F4CA2C1.7070708@redhat.com> (raw)
In-Reply-To: <CAJSP0QWspNM+ESSGjzW1KSXcHJp8RUU+BQxrRzwyZ6cqPVMx1g@mail.gmail.com>
Am 28.02.2012 10:33, schrieb Stefan Hajnoczi:
> On Mon, Feb 27, 2012 at 4:27 PM, Kevin Wolf <kwolf@redhat.com> wrote:
>> + if (ext.len > 65536) {
>> + error_report("Header extension larger than 64k - this looks wrong");
>> + return -ENOTSUP;
>> + }
>
> This is an implementation limit and not in the spec, but I think it's
> reasonable.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Hm, actually, now that I look at this patch again, I think there's a
much better error condition that even matches the spec:
if (offset + ext.len > end_offset)
I'll send a changed version of the patch.
Kevin
next prev parent reply other threads:[~2012-02-28 9:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 16:27 [Qemu-devel] [PATCH] qcow2: Reject unrealistically large header extensions Kevin Wolf
2012-02-28 9:33 ` Stefan Hajnoczi
2012-02-28 9:47 ` Kevin Wolf [this message]
2012-02-28 10:00 ` Stefan Hajnoczi
2012-02-28 10:18 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4CA2C1.7070708@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.