From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zach Brown Subject: Re: [RFC PATCH 00/22] loop: Issue O_DIRECT aio with pages Date: Tue, 28 Feb 2012 10:14:34 -0500 Message-ID: <4F4CEF5A.1020207@zabbo.net> References: <1330377576-3659-1-git-send-email-dave.kleikamp@oracle.com> <20120228092926.GA2766@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Dave Kleikamp , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Christoph Hellwig Return-path: In-Reply-To: <20120228092926.GA2766@infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > For one you make ->aio_read/write trivial wrappers around ->read_iter > and ->write_iter. Instead of keeping this duplication around please > make sure to entirely kill ->aio_read/write and always use your new > methods. Without that we'll get into a complete mess like the old > ->aio_read/write vs ->readv/writev again. > > A similar thing applies to the ->direct_IO/direct_IO_bvec interface - Yeah, that's reasonable. Perhaps obviously, we started with new entry points to minimize the amount of churn we'd have to go through to test the change in behaviour. It's going to be messy to try and abstract away the pinning and dirtying of the iter regions from direct IO through the iter interface, but maybe not horribly so. - z