Re: [PATCH] ACPI, APEI, EINJ, limit the range of einj_param

[Chen Gong <gong.chen@linux.intel.com>]

于 2012/2/29 2:33, Luck, Tony 写道:
>> parameter support.  Or we can fix einj_get_parameter_address() to return
>> NULL if param_extension is 0 and paddrv5 is 0.
>
> That was my intent ... but it looks like I managed to lose that in
> some code re-arrangement.
>
> Perhaps (Outlook will white-space mangle, but it is only one line):
>
> diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
> index 4ca087d..3d3816f 100644
> --- a/drivers/acpi/apei/einj.c
> +++ b/drivers/acpi/apei/einj.c
> @@ -238,7 +238,7 @@ static void *einj_get_parameter_address(void)
>   			return v5param;
>   		}
>   	}
> -	if (paddrv4) {
> +	if (param_extension&&  paddrv4) {
>   		struct einj_parameter *v4param;
>
>   		v4param = acpi_os_map_memory(paddrv4, sizeof(*v4param));
>
>

After combination the opinions from Ying and Tony, the current fix is the
simplest. Any other changes will make codes more complex. So I prefer to
keep current style. What's your opinion?

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html