From: Alex Elder <elder@dreamhost.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 0/6] ceph: virtual extended attribute cleanup
Date: Tue, 28 Feb 2012 21:15:21 -0800 [thread overview]
Message-ID: <4F4DB469.4030109@dreamhost.com> (raw)
In-Reply-To: <20120229042044.GB1865@infradead.org>
On 02/28/2012 08:20 PM, Christoph Hellwig wrote:
> On Tue, Feb 28, 2012 at 07:17:41PM -0800, Alex Elder wrote:
>> This series cleans up some code involving ceph's virtual extended
>> attributes. Three of them define some simple macros are set up to
>> help ensure the attributes are defined in a consistent way. One
>> makes the size of certain constant values get defined at startup
>> time rather than repeatedly, and the remaining two are some very
>> small changes made for clarity.
>
> Is there any reason you can't use the generic_*xattr helpers that
> parse attribute names and use the handler array in the superblock?
We should. And I started to look at that but decided to at least
start moving the code in a better, more regular direction. I've
got it on a list but haven't gotten around to it. Lots of this
stuff is just the result of taking my first walk through some
of this code.
> I'm still vaguely planning on getting all remaining filesystems
> converted over to it.
OK. I'll look into converting this stuff soon.
-Alex
prev parent reply other threads:[~2012-02-29 5:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 3:17 [PATCH 0/6] ceph: virtual extended attribute cleanup Alex Elder
2012-02-29 3:21 ` [PATCH 1/6] ceph: use a symbolic name for "ceph." extended attribute namespace Alex Elder
2012-02-29 3:21 ` [PATCH 2/6] ceph: use macros to normalize vxattr table definitions Alex Elder
2012-02-29 3:21 ` [PATCH 3/6] ceph: drop "_cb" from name of struct ceph_vxattr_cb Alex Elder
2012-02-29 3:21 ` [PATCH 4/6] ceph: encode type in vxattr callback routines Alex Elder
2012-02-29 3:21 ` [PATCH 5/6] ceph: avoid repeatedly computing the size of constant vxattr names Alex Elder
2012-02-29 4:47 ` Yehuda Sadeh Weinraub
2012-02-29 5:19 ` Alex Elder
2012-02-29 3:21 ` [PATCH 6/6] ceph: make ceph_setxattr() and ceph_removexattr() more alike Alex Elder
2012-03-02 19:35 ` Sage Weil
2012-03-03 4:17 ` Alex Elder
2012-02-29 4:20 ` [PATCH 0/6] ceph: virtual extended attribute cleanup Christoph Hellwig
2012-02-29 5:15 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4DB469.4030109@dreamhost.com \
--to=elder@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.