From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tushar Behera Subject: Re: [PATCH 2/3] ARM: EXYNOS: Add clkdev lookup entry for lcd clock Date: Wed, 29 Feb 2012 11:15:12 +0530 Message-ID: <4F4DBB68.6000108@linaro.org> References: <1322718611-20934-1-git-send-email-tushar.behera@linaro.org> <1322718611-20934-3-git-send-email-tushar.behera@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:42248 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932134Ab2B2FpS (ORCPT ); Wed, 29 Feb 2012 00:45:18 -0500 Received: by pbcup15 with SMTP id up15so4168395pbc.19 for ; Tue, 28 Feb 2012 21:45:18 -0800 (PST) In-Reply-To: <1322718611-20934-3-git-send-email-tushar.behera@linaro.org> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: kgene.kim@samsung.com Cc: linux-samsung-soc@vger.kernel.org, linaro-dev@lists.linaro.org, patches@linaro.org Hi Kukjin, On 12/01/2011 11:20 AM, Tushar Behera wrote: > The framebuffer driver needs the clock named 'lcd' as its bus > clock but the equivalent clock on Exynos4 is named as 'fimd'. > Hence, create a clkdev lookup entry with the name 'lcd' that > references the 'fimd' clock. > > Signed-off-by: Tushar Behera > --- > arch/arm/mach-exynos/clock.c | 14 +++++++++----- > 1 files changed, 9 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-exynos/clock.c b/arch/arm/mach-exynos/clock.c > index 5d8d483..607ec28 100644 > --- a/arch/arm/mach-exynos/clock.c > +++ b/arch/arm/mach-exynos/clock.c > @@ -489,11 +489,6 @@ static struct clk init_clocks_off[] = { > .enable = exynos4_clk_ip_cam_ctrl, > .ctrlbit = (1 << 3), > }, { > - .name = "fimd", > - .devname = "exynos4-fb.0", > - .enable = exynos4_clk_ip_lcd0_ctrl, > - .ctrlbit = (1 << 0), > - }, { > .name = "hsmmc", > .devname = "s3c-sdhci.0", > .parent = &clk_aclk_133.clk, > @@ -782,6 +777,13 @@ static struct clk clk_pdma1 = { > .ctrlbit = (1 << 1), > }; > > +static struct clk clk_fimd0 = { > + .name = "fimd", > + .devname = "exynos4-fb.0", > + .enable = exynos4_clk_ip_lcd0_ctrl, > + .ctrlbit = (1 << 0), > +}; > + > struct clk *clkset_group_list[] = { > [0] = &clk_ext_xtal_mux, > [1] = &clk_xusbxti, > @@ -1294,6 +1296,7 @@ static struct clksrc_clk *sysclks[] = { > static struct clk *clk_cdev[] = { > &clk_pdma0, > &clk_pdma1, > + &clk_fimd0, > }; > > static struct clksrc_clk *clksrc_cdev[] = { > @@ -1318,6 +1321,7 @@ static struct clk_lookup exynos4_clk_lookup[] = { > CLKDEV_INIT("s3c-sdhci.3", "mmc_busclk.2", &clk_sclk_mmc3.clk), > CLKDEV_INIT("dma-pl330.0", "apb_pclk", &clk_pdma0), > CLKDEV_INIT("dma-pl330.1", "apb_pclk", &clk_pdma1), > + CLKDEV_INIT("exynos4-fb.0", "lcd", &clk_fimd0), > }; > > static int xtal_rate; Would you please review this patch and let me know your opinion? Without this patch, frame-buffer support on EXYNOS4 is broken. -- Tushar Behera