From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34432)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S2cYH-0006M6-BJ
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 00:58:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S2cYE-0005Qd-Uk
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 00:58:12 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46766)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S2cYE-0005Q7-OL
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 00:58:10 -0500
Message-ID: <4F4DBE6F.5070507@weilnetz.de>
Date: Wed, 29 Feb 2012 06:58:07 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1330465637-23410-1-git-send-email-sw@weilnetz.de>
	<1330465637-23410-10-git-send-email-sw@weilnetz.de>
	<AD431C1EF67D4B4B801AEC089EB7ED48012326D3F0@exchdb03.mips.com>
In-Reply-To: <AD431C1EF67D4B4B801AEC089EB7ED48012326D3F0@exchdb03.mips.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 09/15] target-mips: Clean includes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Johnson, Eric" <ericj@mips.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

Am 29.02.2012 00:51, schrieb Johnson, Eric:
> You may want to just put those includes inside an '#ifdef 
> MIPS_DEBUG_DISAS' instead of removing them.
>
> Although I suppose we could just add back the minimum needed along 
> with the patches to fix the compile when MIPS_DEBUG_DISAS is defined.

Hi Eric,

those includes are redundant. I removed them here, but they are still 
included
(cpu.h includes qemu-common.h which includes the standard includes).
So there is no need for #ifdef MIPS_DEBUG_DISAS.

Compilation with MIPS_DEBUG_DISAS nevertheless fails, but it also fails with
current git master. This is a problem which is not related to my patch 
series.

Cheers,

Stefan W.


>
> -----Original Message-----
> From: qemu-devel-bounces+ericj=mips.com@nongnu.org 
> [mailto:qemu-devel-bounces+ericj=mips.com@nongnu.org] On Behalf Of 
> Stefan Weil
> Sent: Tuesday, February 28, 2012 1:47 PM
> To: Anthony Liguori
> Cc: Stefan Weil; qemu-devel@nongnu.org; Aurelien Jarno
> Subject: [Qemu-devel] [PATCH 09/15] target-mips: Clean includes
>
> Remove some include statements which are not needed.
>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> target-mips/translate.c | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/target-mips/translate.c b/target-mips/translate.c index 
> d5b1c76..8361d88 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -20,16 +20,9 @@
> * License along with this library; if not, see 
> <http://www.gnu.org/licenses/>.
> */
>
> -#include <stdarg.h>
> -#include <stdlib.h>
> -#include <stdio.h>
> -#include <string.h>
> -#include <inttypes.h>
> -
> #include "cpu.h"
> #include "disas.h"
> #include "tcg-op.h"
> -#include "qemu-common.h"
>
> #include "helper.h"
> #define GEN_HELPER 1
> --
> 1.7.9
>
>