From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] OMAPDSS: panel-dvi: Add Kconfig dependency on I2C
Date: Wed, 29 Feb 2012 10:03:45 +0000 [thread overview]
Message-ID: <4F4DF801.3000905@gmx.de> (raw)
In-Reply-To: <1330505302-8258-2-git-send-email-tomi.valkeinen@ti.com>
On 02/29/2012 08:48 AM, Tomi Valkeinen wrote:
> panel-dvi uses i2c, but the Kconfig didn't have dependency on I2C. Add
> it.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> drivers/video/omap2/displays/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/omap2/displays/Kconfig b/drivers/video/omap2/displays/Kconfig
> index 74d29b5..408a992 100644
> --- a/drivers/video/omap2/displays/Kconfig
> +++ b/drivers/video/omap2/displays/Kconfig
> @@ -12,7 +12,7 @@ config PANEL_GENERIC_DPI
>
> config PANEL_DVI
> tristate "DVI output"
> - depends on OMAP2_DSS_DPI
> + depends on OMAP2_DSS_DPI && I2C
It's just a matter of taste, but are you sure you want to "depend" on it and not
"select" it? Other drivers tend to use select for I2C, for me it doesn't really
matter.
Best regards,
Florian Tobias Schandinat
> help
> Driver for external monitors, connected via DVI. The driver uses i2c
> to read EDID information from the monitor.
next prev parent reply other threads:[~2012-02-29 10:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 8:48 [PATCH 0/2] OMAPDSS: small fixes for 3.3 rc Tomi Valkeinen
2012-02-29 8:48 ` Tomi Valkeinen
2012-02-29 8:48 ` [PATCH 1/2] OMAPDSS: panel-dvi: Add Kconfig dependency on I2C Tomi Valkeinen
2012-02-29 8:48 ` Tomi Valkeinen
2012-02-29 10:03 ` Florian Tobias Schandinat [this message]
2012-02-29 10:21 ` Tomi Valkeinen
2012-02-29 10:21 ` Tomi Valkeinen
2012-02-29 11:10 ` Florian Tobias Schandinat
2012-02-29 8:48 ` [PATCH 2/2] OMAPDSS: APPLY: make ovl_enable/disable synchronous Tomi Valkeinen
2012-02-29 8:48 ` Tomi Valkeinen
2012-02-29 10:13 ` Florian Tobias Schandinat
2012-02-29 10:30 ` Tomi Valkeinen
2012-02-29 10:30 ` Tomi Valkeinen
2012-02-29 10:48 ` Florian Tobias Schandinat
2012-02-29 14:52 ` Rob Clark
2012-02-29 14:52 ` Rob Clark
2012-02-29 9:56 ` [PATCH 0/2] OMAPDSS: small fixes for 3.3 rc Florian Tobias Schandinat
2012-03-01 5:38 ` Florian Tobias Schandinat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4DF801.3000905@gmx.de \
--to=florianschandinat@gmx.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.