From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [SeaBIOS] [PATCH RFC] seabios: add OSHP method stub Date: Wed, 29 Feb 2012 12:25:13 +0100 Message-ID: <4F4E0B19.3060605@redhat.com> References: <20120213093223.GA26979@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Kevin Wolf , kvm@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org, Isaku Yamahata , Avi Kivity To: "Michael S. Tsirkin" Return-path: In-Reply-To: <20120213093223.GA26979@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org > diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl > index 442e7a8..3f50169 100644 > --- a/src/ssdt-pcihp.dsl > +++ b/src/ssdt-pcihp.dsl > @@ -24,6 +24,7 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) > ACPI_EXTRACT_METHOD_STRING aml_ej0_name \ > Method (_EJ0, 1) { Return(PCEJ(0x##slot)) } \ > Name (_SUN, 0x##slot) \ > + Method (OSHP, 1) { Return(0x0) } \ > } Linux kernel (kernel-3.2.7-1.fc16.x86_64) complains: ACPI Warning: For \_SB_.PCI0.S10_.OSHP: Insufficient arguments - needs 1, found 0 (20110623/nspredef-321) cheers, Gerd From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2hev-0002dN-Uf for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:25:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2hep-0006z3-Rp for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:25:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2hep-0006yq-Jm for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:25:19 -0500 Message-ID: <4F4E0B19.3060605@redhat.com> Date: Wed, 29 Feb 2012 12:25:13 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <20120213093223.GA26979@redhat.com> In-Reply-To: <20120213093223.GA26979@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH RFC] seabios: add OSHP method stub List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Kevin Wolf , kvm@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org, Isaku Yamahata , Avi Kivity > diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl > index 442e7a8..3f50169 100644 > --- a/src/ssdt-pcihp.dsl > +++ b/src/ssdt-pcihp.dsl > @@ -24,6 +24,7 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) > ACPI_EXTRACT_METHOD_STRING aml_ej0_name \ > Method (_EJ0, 1) { Return(PCEJ(0x##slot)) } \ > Name (_SUN, 0x##slot) \ > + Method (OSHP, 1) { Return(0x0) } \ > } Linux kernel (kernel-3.2.7-1.fc16.x86_64) complains: ACPI Warning: For \_SB_.PCI0.S10_.OSHP: Insufficient arguments - needs 1, found 0 (20110623/nspredef-321) cheers, Gerd