From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2hlG-0005TH-Kr for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:32:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2hkm-00085i-SO for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:31:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2hkm-00085R-KU for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:31:28 -0500 Message-ID: <4F4E0C8A.9040902@redhat.com> Date: Wed, 29 Feb 2012 13:31:22 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20120228175914.GA28479@redhat.com> <4F4D1951.4040807@codemonkey.ws> <4F4D19C5.8030507@redhat.com> <4F4D2789.2070306@codemonkey.ws> <4F4D2848.30007@redhat.com> <4F4D290F.90907@codemonkey.ws> <20120228225805.GA8740@redhat.com> <4F4DF94A.80803@redhat.com> <20120229102306.GA4924@redhat.com> <4F4E03BE.0@redhat.com> <20120229112552.GB5233@redhat.com> In-Reply-To: <20120229112552.GB5233@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] Memory core space reduction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel , Anthony Liguori On 02/29/2012 01:25 PM, Michael S. Tsirkin wrote: > It does not crash under valgrind :) > But valgrid did show some info: > > ==9202== Invalid write of size 8 > ==9202== at 0x2F313D: portio_list_add_1 (ioport.c:379) > Anthony, your "bad bisect" was in fact good - it was the very first patch that was bad: piolist->regions[piolist->nr++] = region; piolist->aliases[piolist->nr++] = alias; will fix. -- error compiling committee.c: too many arguments to function