From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Jeff Cody <jcody@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
Federico Simoncelli <fsimonce@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync
Date: Wed, 29 Feb 2012 15:25:29 +0100 [thread overview]
Message-ID: <4F4E3559.3010801@redhat.com> (raw)
In-Reply-To: <1330522650-15357-4-git-send-email-pbonzini@redhat.com>
Il 29/02/2012 14:37, Paolo Bonzini ha scritto:
> + assert(!(dev_info->snapshot->has_format && format));
Oops, this wanted to be
assert(dev_info->snapshot->has_format == (format != NULL));
but it can just be omitted, I wasn't sure of how QAPI handled optionals.
Paolo
next prev parent reply other threads:[~2012-02-29 14:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 13:37 [Qemu-devel] [PATCH 0/6] Mirrored writes using blockdev-transaction Paolo Bonzini
2012-02-29 13:37 ` [Qemu-devel] [PATCH 1/6] fix format name for backing file Paolo Bonzini
2012-02-29 13:37 ` [Qemu-devel] [PATCH 2/6] qapi: complete implementation of unions Paolo Bonzini
2012-02-29 13:37 ` [Qemu-devel] [PATCH 3/6] rename blockdev-group-snapshot-sync Paolo Bonzini
2012-02-29 14:25 ` Paolo Bonzini [this message]
2012-02-29 15:08 ` Luiz Capitulino
2012-02-29 15:23 ` Paolo Bonzini
2012-03-01 13:30 ` Luiz Capitulino
2012-03-01 13:33 ` Paolo Bonzini
2012-02-29 18:41 ` Eric Blake
2012-03-01 10:18 ` Paolo Bonzini
2012-02-29 13:37 ` [Qemu-devel] [PATCH 4/6] add reuse field Paolo Bonzini
2012-02-29 18:50 ` Eric Blake
2012-03-01 10:22 ` Kevin Wolf
2012-02-29 13:37 ` [Qemu-devel] [PATCH 5/6] Add blkmirror block driver Paolo Bonzini
2012-02-29 14:37 ` Stefan Hajnoczi
2012-02-29 14:56 ` Paolo Bonzini
2012-02-29 19:36 ` Eric Blake
2012-02-29 13:37 ` [Qemu-devel] [PATCH 6/6] add mirroring to blockdev-transaction Paolo Bonzini
2012-02-29 19:47 ` Eric Blake
2012-03-01 6:46 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4E3559.3010801@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=fsimonce@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.