Re: [Qemu-devel] [PATCH] qemu-iotests: Filter out DOS line endings

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]

On 02/29/2012 06:59 AM, Kevin Wolf wrote:
> This one makes it possible to run qemu-iotests on a Windows build using Wine
> and get somewhat meaningful results.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/qemu-iotests/common.filter |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
> index da77ede..fa26b62 100644
> --- a/tests/qemu-iotests/common.filter
> +++ b/tests/qemu-iotests/common.filter
> @@ -140,10 +140,16 @@ _filter_imgfmt()
>      sed -e "s#$IMGFMT#IMGFMT#g"
>  }
>  
> +# Removes \r from messages
> +_filter_win32()
> +{
> +    sed -e 's/\r//g'

POSIX does not require sed to recognize \r as a synonym for carriage
return.  You are better off using tr(1) (tr -d '\r') if all you want to
do is strip carriage returns in a POSIX-compliant manner.  Also be aware
that on Solaris, you have to make sure you are using a PATH that first
finds a POSIX-compliant tr.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]