From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2p5g-0002iy-DV for qemu-devel@nongnu.org; Wed, 29 Feb 2012 14:21:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2p5J-00026J-5E for qemu-devel@nongnu.org; Wed, 29 Feb 2012 14:21:31 -0500 Received: from goliath.siemens.de ([192.35.17.28]:23309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2p5I-00025c-Hr for qemu-devel@nongnu.org; Wed, 29 Feb 2012 14:21:08 -0500 Message-ID: <4F4E7A5D.70104@siemens.com> Date: Wed, 29 Feb 2012 20:19:57 +0100 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] slirp: Fix for requeuing crash, cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefan Weil , Zhi Yong Wu , qemu-devel@nongnu.org, Fabien Chouteau , "Michael S. Tsirkin" On 2012-02-29 20:15, Jan Kiszka wrote: > This is an alternative, more complete approach to fix the requeuing- > related crashes reported recently. See patch 2 for details. The rest are > simple cleanups. > > Please check carefully if I messed something up. Oops, outdated intro. Should have been: "Well, this requeuing bug seems to have a long breath. Previous attempts to fix it (mine included) neglected the fact that we need to walk the queue of pending packets, not just restart from the beginning after a requeue. This version should get it Right(TM). This also comes with a fix for resource cleanups on slirp shutdown. At least valgrind is happy now. Reviews welcome!" Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux