From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Broken ecc.size when switching between sw and hw ecc (beagleboard)
Date: Wed, 29 Feb 2012 15:00:49 -0600 [thread overview]
Message-ID: <4F4E9201.60502@freescale.com> (raw)
In-Reply-To: <4F4E1622.1080807@flatfrog.com>
On 02/29/2012 06:12 AM, Orjan Friberg wrote:
> For the beagleboard, ecc.size is not explicitly set when doing 'nandecc
> sw'. If it's not set for the NAND_ECC_SOFT case in nand_scan_tail, it's
> set to 256 bytes.
>
> When doing 'nandecc hw', ecc.size is set to 512 bytes. Hence, when
> changing back to 'nandecc sw' ecc.size remains at 512 bytes and suddenly
> the format has changed.
>
>
> It seems the current nandecc command needs to set this explicitly, but
> also needs to be augmented to be able to select the newly added 4/8-bit
> BCH ECC.
Yes, that looks like a bug in omap_nand_switch_ecc().
> But it also seems like nandecc selection should be more generic than for
> omap3 (currently it lives in arch/arm/cpu/armv7/omap3/board.c).
ECC mode is normally not something that you want to be runtime
switchable, as changing it usually changes the on-flash format. It also
requires driver cooperation -- the actual implementation (as opposed to
the command-line wrapper) is in drivers/mtd/nand/omap_gpmc.c.
If we end up with multiple drivers that need to expose this sort of
functionality, maybe we can consider moving the command line wrapper to
common code.
-Scott
next prev parent reply other threads:[~2012-02-29 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 12:12 [U-Boot] Broken ecc.size when switching between sw and hw ecc (beagleboard) Orjan Friberg
2012-02-29 21:00 ` Scott Wood [this message]
2012-03-01 9:17 ` Orjan Friberg
2012-03-01 17:32 ` Scott Wood
2012-03-02 8:39 ` Orjan Friberg
2012-03-05 18:58 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4E9201.60502@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.