From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2qe6-0007fV-OD for qemu-devel@nongnu.org; Wed, 29 Feb 2012 16:01:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2qdv-0004gq-Sa for qemu-devel@nongnu.org; Wed, 29 Feb 2012 16:01:10 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:57273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2qdv-0004fx-LN for qemu-devel@nongnu.org; Wed, 29 Feb 2012 16:00:59 -0500 Message-ID: <4F4E9208.6020207@weilnetz.de> Date: Wed, 29 Feb 2012 22:00:56 +0100 From: Stefan Weil MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/4] slirp: Fix for requeuing crash, cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Zhi Yong Wu , qemu-devel@nongnu.org, Fabien Chouteau , "Michael S. Tsirkin" Am 29.02.2012 20:15, schrieb Jan Kiszka: > This is an alternative, more complete approach to fix the requeuing- > related crashes reported recently. See patch 2 for details. The rest are > simple cleanups. > > Please check carefully if I messed something up. > Hi Jan, here is the result of MIPS Malta with your patch series applied: Program received signal SIGSEGV, Segmentation fault. 0x000055555577db5b in slirp_remque (a=0x555556cff360) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/slirp/misc.c:39 39 ((struct quehead *)(element->qh_rlink))->qh_link = element->qh_link; (gdb) i s #0 0x000055555577db5b in slirp_remque (a=0x555556cff360) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/slirp/misc.c:39 #1 0x000055555577b7a2 in if_start (slirp=0x5555564bfb80) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/slirp/if.c:208 #2 0x000055555577b607 in if_output (so=0x555556ea0b70, ifm=0x555556cff9e0) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/slirp/if.c:139 #3 0x000055555577d040 in ip_output (so=0x555556ea0b70, m0=0x555556cff9e0) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/slirp/ip_output.c:84 #4 0x00005555557865d6 in tcp_output (tp=0x555556ea0c20) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/slirp/tcp_output.c:456 #5 0x000055555577ff5a in slirp_select_poll (readfds=0x7fffffffda10, writefds=0x7fffffffda90, xfds=0x7fffffffdb10, select_error=0) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/slirp/slirp.c:480 #6 0x000055555572d8c0 in main_loop_wait (nonblocking=0) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/main-loop.c:469 #7 0x0000555555721a61 in main_loop () at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/vl.c:1558 #8 0x00005555557284a2 in main (argc=25, argv=0x7fffffffdfe8, envp=0x7fffffffe0b8) at /home/stefan/src/qemu/repo.or.cz/qemu/ar7/vl.c:3667 (gdb) p element $1 = (struct quehead *) 0x555556cff360 (gdb) p *element $2 = {qh_link = 0x555556cff360, qh_rlink = 0x0} (gdb) p (struct quehead *)(element->qh_rlink) $3 = (struct quehead *) 0x0 Cheers, Stefan