From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com ([143.182.124.37]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1S2rDR-0003Hu-Fm for bitbake-devel@lists.openembedded.org; Wed, 29 Feb 2012 22:37:41 +0100 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by azsmga102.ch.intel.com with ESMTP; 29 Feb 2012 13:29:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="112979653" Received: from unknown (HELO [10.255.15.102]) ([10.255.15.102]) by azsmga001.ch.intel.com with ESMTP; 29 Feb 2012 13:29:14 -0800 Message-ID: <4F4E98AA.9010204@linux.intel.com> Date: Wed, 29 Feb 2012 13:29:14 -0800 From: Joshua Lock User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 MIME-Version: 1.0 To: bitbake-devel@lists.openembedded.org References: <439e7e3c5dd2534950c63d9df57963f1a3d35944.1330523904.git.shane.wang@intel.com> In-Reply-To: Subject: Re: [PATCH 09/32] Hob: fix a bug in builder.configuration.curr_mach X-BeenThere: bitbake-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Feb 2012 21:37:41 -0000 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit On 29/02/12 06:15, Shane Wang wrote: > When the user changes the machine to be "--select a machine--", the builder.configuration.curr_mach should be set to empty. > Otherwise, if the user adds more layers after the above, the action will trigger recipe parsing, which is not correct. > > Signed-off-by: Shane Wang Signed-off-by: Joshua Lock > --- > bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py b/bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py > index 4083360..cd86606 100644 > --- a/bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py > +++ b/bitbake/lib/bb/ui/crumbs/imageconfigurationpage.py > @@ -243,6 +243,7 @@ class ImageConfigurationPage (HobPage): > def machine_combo_changed_cb(self, machine_combo): > combo_item = machine_combo.get_active_text() > if not combo_item or combo_item == self.__dummy_machine__: > + self.builder.configuration.curr_mach = "" > self.builder.switch_page(self.builder.MACHINE_SELECTION) > else: > self.builder.configuration.curr_mach = combo_item -- Joshua Lock Yocto Project "Johannes factotum" Intel Open Source Technology Centre