* [Qemu-trivial] [PATCH] pc: make user-triggerable exit conditional to DEBUG_BIOS define
@ 2012-02-29 22:44 ` Hervé Poussineau
0 siblings, 0 replies; 6+ messages in thread
From: Hervé Poussineau @ 2012-02-29 22:44 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Anthony Liguori, Hervé Poussineau
The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/pc.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 12c02f2..113a38a 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
/* LGPL'ed VGA BIOS messages */
case 0x501:
case 0x502:
+#ifdef DEBUG_BIOS
exit((val << 1) | 1);
+#endif
+ break;
case 0x500:
case 0x503:
#ifdef DEBUG_BIOS
--
1.7.9
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] pc: make user-triggerable exit conditional to DEBUG_BIOS define
@ 2012-02-29 22:44 ` Hervé Poussineau
0 siblings, 0 replies; 6+ messages in thread
From: Hervé Poussineau @ 2012-02-29 22:44 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Anthony Liguori, Hervé Poussineau
The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
hw/pc.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 12c02f2..113a38a 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
/* LGPL'ed VGA BIOS messages */
case 0x501:
case 0x502:
+#ifdef DEBUG_BIOS
exit((val << 1) | 1);
+#endif
+ break;
case 0x500:
case 0x503:
#ifdef DEBUG_BIOS
--
1.7.9
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] pc: make user-triggerable exit conditional to DEBUG_BIOS define
2012-02-29 22:44 ` [Qemu-devel] " Hervé Poussineau
@ 2012-03-01 1:55 ` Anthony Liguori
-1 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2012-03-01 1:55 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-trivial, Anthony Liguori, qemu-devel
On 02/29/2012 04:44 PM, Hervé Poussineau wrote:
> The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.
For what? What device would normally be there?
I don't want to disable this by default. My regression suite depends on this as
an exit mechanism.
Regards,
Anthony Liguori
>
> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
> ---
> hw/pc.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 12c02f2..113a38a 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
> /* LGPL'ed VGA BIOS messages */
> case 0x501:
> case 0x502:
> +#ifdef DEBUG_BIOS
> exit((val<< 1) | 1);
> +#endif
> + break;
> case 0x500:
> case 0x503:
> #ifdef DEBUG_BIOS
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] pc: make user-triggerable exit conditional to DEBUG_BIOS define
@ 2012-03-01 1:55 ` Anthony Liguori
0 siblings, 0 replies; 6+ messages in thread
From: Anthony Liguori @ 2012-03-01 1:55 UTC (permalink / raw)
To: Hervé Poussineau; +Cc: qemu-trivial, Anthony Liguori, qemu-devel
On 02/29/2012 04:44 PM, Hervé Poussineau wrote:
> The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.
For what? What device would normally be there?
I don't want to disable this by default. My regression suite depends on this as
an exit mechanism.
Regards,
Anthony Liguori
>
> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
> ---
> hw/pc.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 12c02f2..113a38a 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque, uint32_t addr, uint32_t val)
> /* LGPL'ed VGA BIOS messages */
> case 0x501:
> case 0x502:
> +#ifdef DEBUG_BIOS
> exit((val<< 1) | 1);
> +#endif
> + break;
> case 0x500:
> case 0x503:
> #ifdef DEBUG_BIOS
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] pc: make user-triggerable exit conditional to DEBUG_BIOS define
2012-03-01 1:55 ` Anthony Liguori
@ 2012-03-01 6:42 ` Hervé Poussineau
-1 siblings, 0 replies; 6+ messages in thread
From: Hervé Poussineau @ 2012-03-01 6:42 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-trivial, Anthony Liguori, qemu-devel
Hi,
I've no idea what installer is trying to do with this port, or what
device it is probing.
We can maybe add a runtime switch to exit Qemu or not. What do you think
of '-vgabios-backdoor' which, if specified, does the exit ?
Otherwise, which solution do you propose?
Regards,
Hervé
Anthony Liguori a écrit :
> On 02/29/2012 04:44 PM, Hervé Poussineau wrote:
>> The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.
>
> For what? What device would normally be there?
>
> I don't want to disable this by default. My regression suite depends on
> this as an exit mechanism.
>
> Regards,
>
> Anthony Liguori
>
>>
>> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
>> ---
>> hw/pc.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pc.c b/hw/pc.c
>> index 12c02f2..113a38a 100644
>> --- a/hw/pc.c
>> +++ b/hw/pc.c
>> @@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque,
>> uint32_t addr, uint32_t val)
>> /* LGPL'ed VGA BIOS messages */
>> case 0x501:
>> case 0x502:
>> +#ifdef DEBUG_BIOS
>> exit((val<< 1) | 1);
>> +#endif
>> + break;
>> case 0x500:
>> case 0x503:
>> #ifdef DEBUG_BIOS
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] pc: make user-triggerable exit conditional to DEBUG_BIOS define
@ 2012-03-01 6:42 ` Hervé Poussineau
0 siblings, 0 replies; 6+ messages in thread
From: Hervé Poussineau @ 2012-03-01 6:42 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-trivial, Anthony Liguori, qemu-devel
Hi,
I've no idea what installer is trying to do with this port, or what
device it is probing.
We can maybe add a runtime switch to exit Qemu or not. What do you think
of '-vgabios-backdoor' which, if specified, does the exit ?
Otherwise, which solution do you propose?
Regards,
Hervé
Anthony Liguori a écrit :
> On 02/29/2012 04:44 PM, Hervé Poussineau wrote:
>> The port 0x501 is (at least) used by SCO Xenix 2.3.4 installer.
>
> For what? What device would normally be there?
>
> I don't want to disable this by default. My regression suite depends on
> this as an exit mechanism.
>
> Regards,
>
> Anthony Liguori
>
>>
>> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
>> ---
>> hw/pc.c | 3 +++
>> 1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/pc.c b/hw/pc.c
>> index 12c02f2..113a38a 100644
>> --- a/hw/pc.c
>> +++ b/hw/pc.c
>> @@ -565,7 +565,10 @@ static void bochs_bios_write(void *opaque,
>> uint32_t addr, uint32_t val)
>> /* LGPL'ed VGA BIOS messages */
>> case 0x501:
>> case 0x502:
>> +#ifdef DEBUG_BIOS
>> exit((val<< 1) | 1);
>> +#endif
>> + break;
>> case 0x500:
>> case 0x503:
>> #ifdef DEBUG_BIOS
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-03-01 6:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-29 22:44 [Qemu-trivial] [PATCH] pc: make user-triggerable exit conditional to DEBUG_BIOS define Hervé Poussineau
2012-02-29 22:44 ` [Qemu-devel] " Hervé Poussineau
2012-03-01 1:55 ` [Qemu-trivial] " Anthony Liguori
2012-03-01 1:55 ` Anthony Liguori
2012-03-01 6:42 ` [Qemu-trivial] " Hervé Poussineau
2012-03-01 6:42 ` Hervé Poussineau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.