From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhengwang Ruan Date: Thu, 01 Mar 2012 02:08:56 +0000 Subject: Re: [PATCH] Trace: initialize variable to clear warning Message-Id: <4F4EDA38.2070803@gmail.com> List-Id: References: <1330420174-20537-1-git-send-email-ruan.zhengwang@gmail.com> <1330438591.25686.214.camel@gandalf.stny.rr.com> <48875.1330555230@turing-police.cc.vt.edu> <1330564158.25686.230.camel@gandalf.stny.rr.com> In-Reply-To: <1330564158.25686.230.camel@gandalf.stny.rr.com> MIME-Version: 1.0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 To: Steven Rostedt Cc: Valdis.Kletnieks@vt.edu, fweisbec@gmail.com, mingo@redhat.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org CgoKLS0tLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLS0tLQpGcm9tOiBTdGV2ZW4gUm9zdGVk dApTZW50OiAyMDEyxOowMtTCMjnI1SDQx8bayP0gMjDKsTA5t9YxOMPrClRvOiBWYWxkaXMuS2xl dG5pZWtzClN1YmplY3Q6IFJlOiBbUEFUQ0hdIFRyYWNlOiBpbml0aWFsaXplIHZhcmlhYmxlIHRv IGNsZWFyIHdhcm5pbmcKPiBPbiBXZWQsIDIwMTItMDItMjkgYXQgMTc6NDAgLTA1MDAsIFZhbGRp cy5LbGV0bmlla3NAdnQuZWR1IHdyb3RlOgo+PiBPbiBUdWUsIDI4IEZlYiAyMDEyIDA5OjE2OjMx IEVTVCwgU3RldmVuIFJvc3RlZHQgc2FpZDoKPj4KPj4+IFRoaXMgaXMgYSBidWcgaW4gZ2NjIHRo YXQncyBmaXhlZCBpbiA0LjYgYW5kIGJleW9uZC4gSSBkb24ndCB3YW50IHRvCj4+PiByZW1vdmUg dGhpcyB3YXJuaW5nIGJlY2F1c2UgaXQgd2lsbCBoaWRlIGEgcmVhbCBidWcgaWYgcGFnZTIgcmVh bGx5IGRvZXMKPj4+IGJlY29tZSB1bmluaXRpYWxpemVkLiBJZiA0LjYgZ2l2ZXMgYSB3YXJuaW5n IGhlcmUsIHRoZW4gSSdsbCBmaXggaXQuCj4+Pj4gLQl2b2lkICpwYWdlMjsKPj4+PiArCXZvaWQg KnVuaW5pdGlhbGl6ZWRfdmFyKHBhZ2UyKTsKPj4gSG93IHdvdWxkIHlvdSBmZWVsIGFib3V0IHRo aXM/Cj4+Cj4+IC0Jdm9pZCAqcGFnZTI7Cj4+ICsJdm9pZCAqcGFnZTI7IC8qIGdjYyA0LjUgYnVn IGNhdXNlcyBpbmNvcnJlY3QgInVuaW5pdGlhbGl6ZWQiIHdhcm5pbmcgKi8KPj4KPj4gb3Igc29t ZXRoaW5nIHNpbWlsYXI/Cj4gLyogaWYgeW91IGdldCBhIHdhcm5pbmcgaGVyZSwgdXBncmFkZSB5 b3VyIGdjYyB0byA0LjYgKi8KPgoKT0ssIEkgd2lsbCByZXNlbmQgdGhpcyBwYXRjaC4KClRoYW5r cywKLVpoZW5nd2FuZwoKPiAtLSBTdGV2ZQo+Cj4KPgo+CgotLQpUbyB1bnN1YnNjcmliZSBmcm9t IHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUga2VybmVsLWphbml0b3JzIiBp bgp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3Jl IG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZv Lmh0bWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754695Ab2CACGA (ORCPT ); Wed, 29 Feb 2012 21:06:00 -0500 Received: from mail-yx0-f174.google.com ([209.85.213.174]:32845 "EHLO mail-yx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303Ab2CACF6 (ORCPT ); Wed, 29 Feb 2012 21:05:58 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of ruan.zhengwang@gmail.com designates 10.101.136.35 as permitted sender) smtp.mail=ruan.zhengwang@gmail.com; dkim=pass header.i=ruan.zhengwang@gmail.com Message-ID: <4F4EDA38.2070803@gmail.com> Date: Thu, 01 Mar 2012 10:08:56 +0800 From: Zhengwang Ruan User-Agent: Mozilla/5.0 (X11; U; Linux i686; zh-CN; rv:1.9.2.15) Gecko/20110303 Lightning/1.0b2 Thunderbird/3.1.9 MIME-Version: 1.0 To: Steven Rostedt CC: Valdis.Kletnieks@vt.edu, fweisbec@gmail.com, mingo@redhat.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Trace: initialize variable to clear warning References: <1330420174-20537-1-git-send-email-ruan.zhengwang@gmail.com> <1330438591.25686.214.camel@gandalf.stny.rr.com> <48875.1330555230@turing-police.cc.vt.edu> <1330564158.25686.230.camel@gandalf.stny.rr.com> In-Reply-To: <1330564158.25686.230.camel@gandalf.stny.rr.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org -------- Original Message -------- From: Steven Rostedt Sent: 2012年02月29日 星期三 20时09分18秒 To: Valdis.Kletnieks Subject: Re: [PATCH] Trace: initialize variable to clear warning > On Wed, 2012-02-29 at 17:40 -0500, Valdis.Kletnieks@vt.edu wrote: >> On Tue, 28 Feb 2012 09:16:31 EST, Steven Rostedt said: >> >>> This is a bug in gcc that's fixed in 4.6 and beyond. I don't want to >>> remove this warning because it will hide a real bug if page2 really does >>> become uninitialized. If 4.6 gives a warning here, then I'll fix it. >>>> - void *page2; >>>> + void *uninitialized_var(page2); >> How would you feel about this? >> >> - void *page2; >> + void *page2; /* gcc 4.5 bug causes incorrect "uninitialized" warning */ >> >> or something similar? > /* if you get a warning here, upgrade your gcc to 4.6 */ > OK, I will resend this patch. Thanks, -Zhengwang > -- Steve > > > >