From mboxrd@z Thu Jan 1 00:00:00 1970 From: Viresh Kumar Subject: Re: [PATCH 2/2] i2c/designware: Provide optional i2c bus recovery function Date: Thu, 1 Mar 2012 12:05:01 +0530 Message-ID: <4F4F1895.2080100@st.com> References: <0ca1d8990c23a45193a32d0e7e889620b995af59.1330082915.git.viresh.kumar@st.com> <351031347b845920a0ea78e7491d955137e3d7aa.1330082915.git.viresh.kumar@st.com> <4F4B3072.6050903@nvidia.com> <4F4B569F.3080607@st.com> <4F4B5A9A.4050303@st.com> <4F4E118B.2030403@nvidia.com> <4F4F12EC.1020703@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4F4F12EC.1020703-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: viresh kumar , Rajeev KUMAR , Deepak SIKRI , "khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org" , Shubhrajyoti Datta , Vipin KUMAR , Bhupesh SHARMA , Mirko GARDI , "w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org" , Vincenzo FRASCINO , Bhavna YADAV , Armando VISCONTI , Shiraz HASHIM , Salvatore DE DOMINICIS , "ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Pratyush ANAND , Amit VIRDI , Vipul Kumar SAMAR List-Id: linux-i2c@vger.kernel.org On 3/1/2012 11:40 AM, Laxman Dewangan wrote: > Most of the socs have i2c pin as open drain type. By having this flag we can tell that in is whether open drain type or not. > There is patch to support open drain in gpiolib which is under review. Ok. Got it now. I will add gpio_flags in struct i2c_bus_recovery_info. If it is non-zero, will use it, otherwise use default flags (GPIOF_DIR_OUT | GPIOF_INIT_LOW). -- viresh