Re: [PATCH 2/4] bnx2fc: Remove bh disable in softirq context

Re: [PATCH 2/4] bnx2fc: Remove bh disable in softirq context

[Bhanu Prakash Gollapudi]

On 2/27/2012 11:22 AM, Neil Horman wrote:
> As with the fcoe sw transport, the bnx2fc packet handler function runs only in
> softirq context.  Theres no need to disable bottom halves here
>
> Signed-off-by: Neil Horman<nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
> CC: Bhanu Prakash Gollapudi<bprakash-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
> CC: "James E.J. Bottomley"<JBottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
> CC: Vasu Dev<vasu.dev-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> CC: robert.w.love-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
> ---
>   drivers/scsi/bnx2fc/bnx2fc_fcoe.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index 8c6156a..34b4a34 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -440,13 +440,13 @@ static int bnx2fc_rcv(struct sk_buff *skb, struct net_device *dev,
>   	fr->fr_dev = lport;
>
>   	bg =&bnx2fc_global;
> -	spin_lock_bh(&bg->fcoe_rx_list.lock);
> +	spin_lock(&bg->fcoe_rx_list.lock);
>
>   	__skb_queue_tail(&bg->fcoe_rx_list, skb);
>   	if (bg->fcoe_rx_list.qlen == 1)
>   		wake_up_process(bg->thread);
>
> -	spin_unlock_bh(&bg->fcoe_rx_list.lock);
> +	spin_unlock(&bg->fcoe_rx_list.lock);
>
>   	return 0;
>   err:
Changes look good to me.  Thanks.

Acked-by: Bhanu Prakash Gollapudi <bprakash-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>