From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S311u-0007D8-UV for qemu-devel@nongnu.org; Thu, 01 Mar 2012 03:06:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S311g-0000GL-C4 for qemu-devel@nongnu.org; Thu, 01 Mar 2012 03:06:26 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51293 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S311g-0000Fj-5H for qemu-devel@nongnu.org; Thu, 01 Mar 2012 03:06:12 -0500 Message-ID: <4F4F2DF1.8030906@suse.de> Date: Thu, 01 Mar 2012 09:06:09 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1330530051-20404-1-git-send-email-paul@codesourcery.com> In-Reply-To: <1330530051-20404-1-git-send-email-paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Userspace ARM BE8 support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Peter Maydell , Riku Voipio , qemu-devel@nongnu.org Am 29.02.2012 16:40, schrieb Paul Brook: > Add support for ARM BE8 userspace binaries. > i.e. big-endian data and little-endian code. > In principle LE8 mode is also possible, but AFAIK has never actually > been implemented/used. >=20 > System emulation doesn't have any useable big-endian board models, > but should in principle work once you fix that. > Dynamic iendianness switching requires messing with data accesses, > preferably with TCG cooperation, and is orthogonal to BE8 support. >=20 > Signed-off-by: Paul Brook Patch looks good in general. There's some braces missing though for ifs: It's considered mandatory for new code, and we usually fix up old code that we touch. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg