From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S355j-0005ZD-TD for mharc-grub-devel@gnu.org; Thu, 01 Mar 2012 07:26:39 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S355K-0005Y5-OY for grub-devel@gnu.org; Thu, 01 Mar 2012 07:26:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S354u-0003Od-Tp for grub-devel@gnu.org; Thu, 01 Mar 2012 07:26:14 -0500 Received: from mail-ey0-f169.google.com ([209.85.215.169]:33697) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S354u-0003Nu-II for grub-devel@gnu.org; Thu, 01 Mar 2012 07:25:48 -0500 Received: by eaal1 with SMTP id l1so174196eaa.0 for ; Thu, 01 Mar 2012 04:25:46 -0800 (PST) Received-SPF: pass (google.com: domain of phcoder@gmail.com designates 10.14.200.196 as permitted sender) client-ip=10.14.200.196; Authentication-Results: mr.google.com; spf=pass (google.com: domain of phcoder@gmail.com designates 10.14.200.196 as permitted sender) smtp.mail=phcoder@gmail.com; dkim=pass header.i=phcoder@gmail.com Received: from mr.google.com ([10.14.200.196]) by 10.14.200.196 with SMTP id z44mr2855628een.116.1330604746625 (num_hops = 1); Thu, 01 Mar 2012 04:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=LpZQuzGtBFQM1JWLYFOXDIiiRBF+zAA0WNALcAiSfpM=; b=wtZ1myLeWj4jGEuMib5m75o2NQw9I5x9FqBOm6hchjn25zWmydLTpjJtpbR63y4Eq5 5lFtRVLLIVsJSn4C/7OC2sTS3D+EAnBLW7Vi1wv8D7eJDG82EyRQny+GRh6y8vN1T/VA BtnjFjRKJuu0Azwgvz5E8QtsuND2u2815MrJ8= Received: by 10.14.200.196 with SMTP id z44mr2191594een.116.1330604746434; Thu, 01 Mar 2012 04:25:46 -0800 (PST) Received: from debian.x201.phnet (39-234.197-178.cust.bluewin.ch. [178.197.234.39]) by mx.google.com with ESMTPS id y14sm6727838eef.10.2012.03.01.04.25.43 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 01 Mar 2012 04:25:44 -0800 (PST) Message-ID: <4F4F6AC5.8060702@gmail.com> Date: Thu, 01 Mar 2012 13:25:41 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [Q] Indentation rules for GRUB source code References: <4F4F6704.6090203@anvo-it.de> In-Reply-To: <4F4F6704.6090203@anvo-it.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.215.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2012 12:26:38 -0000 On 01.03.2012 13:09, Andreas Vogel wrote: > I tried to find all relevant docs and read what I've found (e.g. > grub-dev.texi), so please excuse me if this questions has been already > answered somewhere. > > I would like to change and submit code for GRUB and from what i see > right now indentation of the code doesn't seem to follow any rules. Most > of the time the visible indentation is 2 spaces which is either achieved > by using a TAB (which needs that the editor is configured to show TABs > as 2 spaces) or it's done by just using 2 spaces. We use GNU identation as described in GCS (http://www.gnu.org/prep/standards/) and as is the default in emacs and "indent" except some imported code which may follow other modes for practical reasons > > Regarding to what code I've seen until now, the indentation of quite a > lot of code is messed up and makes reading more difficult. Displays fine here in emacs > What are the preferred rules to follow when submitting changes or new > code regarding indentation? Run indent on all new code. > > BTW, it might be a good idea to propose the TAB setting configurations > for the most popular editors, e.g. I'm using vim right now. it's the standard GNU one. > Andreas > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'φ-coder/phcoder' Serbinenko