From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S364I-0006un-JW for mharc-grub-devel@gnu.org; Thu, 01 Mar 2012 08:29:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S364B-0006uT-A2 for grub-devel@gnu.org; Thu, 01 Mar 2012 08:29:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3643-000146-LP for grub-devel@gnu.org; Thu, 01 Mar 2012 08:29:06 -0500 Received: from wp191.webpack.hosteurope.de ([80.237.132.198]:49921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3643-00012q-D7 for grub-devel@gnu.org; Thu, 01 Mar 2012 08:28:59 -0500 Received: from p54ba6680.dip.t-dialin.net ([84.186.102.128] helo=neptun.omega.ssw.de); authenticated by wp191.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) id 1S3641-000380-DQ; Thu, 01 Mar 2012 14:28:57 +0100 Received: from localhost (localhost [127.0.0.1]) by neptun.omega.ssw.de (Postfix) with ESMTP id 7DC16E180A8 for ; Thu, 1 Mar 2012 14:28:56 +0100 (CET) X-Virus-Scanned: amavisd-new at omega.ssw.de Received: from neptun.omega.ssw.de ([127.0.0.1]) by localhost (neptun.omega.ssw.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3tYWITICqy7o for ; Thu, 1 Mar 2012 14:28:42 +0100 (CET) Received: from [192.168.2.43] (p640.fritz.box [192.168.2.43]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by neptun.omega.ssw.de (Postfix) with ESMTP id 152CDE180A7 for ; Thu, 1 Mar 2012 14:28:42 +0100 (CET) Message-ID: <4F4F798E.3060101@anvo-it.de> Date: Thu, 01 Mar 2012 14:28:46 +0100 From: Andreas Vogel User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [Q] Indentation rules for GRUB source code References: <4F4F6704.6090203@anvo-it.de> <4F4F6AC5.8060702@gmail.com> In-Reply-To: <4F4F6AC5.8060702@gmail.com> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-bounce-key: webpack.hosteurope.de; andreas.vogel@anvo-it.de; 1330608539; 8348cdbc; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.237.132.198 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Mar 2012 13:29:13 -0000 Thanks for clarification and the pointer to GCS. Just for reference: the appropriate indentation setting for VIM is set tabstop=3D8 softtabstop=3D2 shiftwidth=3D2 noexpandtab so that indentation is 2 spaces and each bunch of 8 spaces will be converted into a TAB char. Andreas Am 01.03.2012 13:25, schrieb Vladimir '=CF=86-coder/phcoder' Serbinenko: > On 01.03.2012 13:09, Andreas Vogel wrote: >> I tried to find all relevant docs and read what I've found (e.g. >> grub-dev.texi), so please excuse me if this questions has been already= >> answered somewhere. >> >> I would like to change and submit code for GRUB and from what i see >> right now indentation of the code doesn't seem to follow any rules. Mo= st >> of the time the visible indentation is 2 spaces which is either achiev= ed >> by using a TAB (which needs that the editor is configured to show TABs= >> as 2 spaces) or it's done by just using 2 spaces. > We use GNU identation as described in GCS > (http://www.gnu.org/prep/standards/) > and as is the default in emacs and "indent" except some imported code > which may follow other modes for practical reasons >> >> Regarding to what code I've seen until now, the indentation of quite a= >> lot of code is messed up and makes reading more difficult. > Displays fine here in emacs >> What are the preferred rules to follow when submitting changes or new >> code regarding indentation? > Run indent on all new code. >> >> BTW, it might be a good idea to propose the TAB setting configurations= >> for the most popular editors, e.g. I'm using vim right now. > it's the standard GNU one. >> Andreas >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel >>