Re: [Qemu-devel] [PATCH 03/11] audio: use a nominal volume of 1^32-1

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

On 03/01/2012 07:27 AM, Marc-André Lureau wrote:
> So we can easily fit it into smaller int.

Fix your subject.  1^32-1 is 0; you meant 2^32 - 1.

> 
> We can just >>16 to fit it into a 16bits volume range for example.
> ---
>  audio/audio.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/audio/audio.c b/audio/audio.c
> index bd9237e..9ea5b39 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -110,8 +110,8 @@ const struct mixeng_volume nominal_volume = {
>      .r = 1.0,
>      .l = 1.0,
>  #else
> -    .r = 1ULL << 32,
> -    .l = 1ULL << 32,
> +    .r = (1ULL << 32) - 1,
> +    .l = (1ULL << 32) - 1,
>  #endif
>  };
>  

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]