From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH resend 1/2] drm: Fix EDID color fromat parsing Date: Thu, 01 Mar 2012 20:26:40 +0100 Message-ID: <4F4FCD70.6020806@metafoo.de> References: <1330420905-6137-1-git-send-email-lars@metafoo.de> <20120228100429.10a52637@jbarnes-desktop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mailhost.informatik.uni-hamburg.de (mailhost.informatik.uni-hamburg.de [134.100.9.70]) by gabe.freedesktop.org (Postfix) with ESMTP id EFA2C9E81E for ; Thu, 1 Mar 2012 11:36:07 -0800 (PST) In-Reply-To: <20120228100429.10a52637@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 02/28/2012 07:04 PM, Jesse Barnes wrote: > On Tue, 28 Feb 2012 10:21:44 +0100 > Lars-Peter Clausen wrote: > >> The code should obviously check the EDID feature field for EDID feature flags >> and not the color_formats field of the drm_display_info struct. Also update the >> color_formats field with new modes instead of overwriting the current mode. >> >> Signed-off-by: Lars-Peter Clausen >> --- >> drivers/gpu/drm/drm_edid.c | 8 ++++---- >> 1 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c >> index 7ee7be1..a6bb2f5 100644 >> --- a/drivers/gpu/drm/drm_edid.c >> +++ b/drivers/gpu/drm/drm_edid.c >> @@ -1700,10 +1700,10 @@ static void drm_add_display_info(struct edid *edid, >> } >> >> info->color_formats = DRM_COLOR_FORMAT_RGB444; >> - if (info->color_formats & DRM_EDID_FEATURE_RGB_YCRCB444) >> - info->color_formats = DRM_COLOR_FORMAT_YCRCB444; >> - if (info->color_formats & DRM_EDID_FEATURE_RGB_YCRCB422) >> - info->color_formats = DRM_COLOR_FORMAT_YCRCB422; >> + if (edid->features & DRM_EDID_FEATURE_RGB_YCRCB444) >> + info->color_formats |= DRM_COLOR_FORMAT_YCRCB444; >> + if (edid->features & DRM_EDID_FEATURE_RGB_YCRCB422) >> + info->color_formats |= DRM_COLOR_FORMAT_YCRCB422; >> >> /* Get data from CEA blocks if present */ >> edid_ext = drm_find_cea_extension(edid); > > Ah that's better. Do you have a TV that reports these feature bits? > If so, which model? No, I just stumbled upon it when implementing patch 2 of this series. > > Reviewed-by: Jesse Barnes >