From: Jin Park <jinyoungp@nvidia.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] regulator: Add a pointer to aat2870_data in struct aat2870_regulator
Date: Fri, 2 Mar 2012 14:14:11 +0900 [thread overview]
Message-ID: <4F505723.9000103@nvidia.com> (raw)
In-Reply-To: <1330651724.6247.3.camel@phoenix>
Acked-by: Jin Park <jinyoungp@nvidia.com>
On 2012-03-02 오전 10:28, Axel Lin wrote:
> The reason we add *pdev in struct aat2870_regulator is to use it
> to get a pointer to struct aat2870_data.
> Save a pointer to struct aat2870_data instead of pdev in struct
> aat2870_regulator, this change makes the intention more clear.
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
> drivers/regulator/aat2870-regulator.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
> index 685ad43..9ed5c5d 100644
> --- a/drivers/regulator/aat2870-regulator.c
> +++ b/drivers/regulator/aat2870-regulator.c
> @@ -31,7 +31,7 @@
> #include<linux/mfd/aat2870.h>
>
> struct aat2870_regulator {
> - struct platform_device *pdev;
> + struct aat2870_data *aat2870;
> struct regulator_desc desc;
>
> const int *voltages; /* uV */
> @@ -60,7 +60,7 @@ static int aat2870_ldo_set_voltage_sel(struct regulator_dev *rdev,
> unsigned selector)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
>
> return aat2870->update(aat2870, ri->voltage_addr, ri->voltage_mask,
> selector<< ri->voltage_shift);
> @@ -69,7 +69,7 @@ static int aat2870_ldo_set_voltage_sel(struct regulator_dev *rdev,
> static int aat2870_ldo_get_voltage_sel(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
> u8 val;
> int ret;
>
> @@ -83,7 +83,7 @@ static int aat2870_ldo_get_voltage_sel(struct regulator_dev *rdev)
> static int aat2870_ldo_enable(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
>
> return aat2870->update(aat2870, ri->enable_addr, ri->enable_mask,
> ri->enable_mask);
> @@ -92,7 +92,7 @@ static int aat2870_ldo_enable(struct regulator_dev *rdev)
> static int aat2870_ldo_disable(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
>
> return aat2870->update(aat2870, ri->enable_addr, ri->enable_mask, 0);
> }
> @@ -100,7 +100,7 @@ static int aat2870_ldo_disable(struct regulator_dev *rdev)
> static int aat2870_ldo_is_enabled(struct regulator_dev *rdev)
> {
> struct aat2870_regulator *ri = rdev_get_drvdata(rdev);
> - struct aat2870_data *aat2870 = dev_get_drvdata(ri->pdev->dev.parent);
> + struct aat2870_data *aat2870 = ri->aat2870;
> u8 val;
> int ret;
>
> @@ -185,7 +185,7 @@ static int aat2870_regulator_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "Invalid device ID, %d\n", pdev->id);
> return -EINVAL;
> }
> - ri->pdev = pdev;
> + ri->aat2870 = dev_get_drvdata(pdev->dev.parent);
>
> rdev = regulator_register(&ri->desc,&pdev->dev,
> pdev->dev.platform_data, ri, NULL);
next prev parent reply other threads:[~2012-03-02 5:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 1:28 [PATCH] regulator: Add a pointer to aat2870_data in struct aat2870_regulator Axel Lin
2012-03-02 5:14 ` Jin Park [this message]
2012-03-02 11:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F505723.9000103@nvidia.com \
--to=jinyoungp@nvidia.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.