From: Stephane Grosjean <s.grosjean@peak-system.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>,
Oliver Hartkopp <socketcan@hartkopp.net>
Cc: linux-can Mailing List <linux-can@vger.kernel.org>
Subject: Re: [PATCH 1/3 v7] can/usb: PEAK-System Technik USB adapters driver core
Date: Fri, 02 Mar 2012 10:29:15 +0100 [thread overview]
Message-ID: <4F5092EB.9000303@peak-system.com> (raw)
In-Reply-To: <4F4FB03C.9030003@pengutronix.de>
So, to confirm once for all:
a serie of patches could define several additions/changes to the same file?
> > I asked myself, why this was optimized in this way. IMO adding
> >
> > 1. PCIEC support
> > 2. PCMCIA support
> >
> > within two patches would be better, right?
> Yes:
> 1. add PCIEC in Kconfig + .c file changes
> 2. add PCMCIA in Kconfig and Makefile + new .c file
> diff --git a/drivers/net/can/usb/peak_usb/Makefile b/drivers/net/can/usb/peak_usb/Makefile
> new file mode 100644
> index 0000000..1aefbc8
> --- /dev/null
> +++ b/drivers/net/can/usb/peak_usb/Makefile
> @@ -0,0 +1,2 @@
> +obj-$(CONFIG_CAN_PEAK_USB) += peak_usb.o
> +peak_usb-y = pcan_usb_core.o pcan_usb.o pcan_usb_pro.o
> Same problem with bisecability here, please fix.
--
PEAK-System Technik GmbH, Otto-Roehm-Strasse 69, D-64293 Darmstadt
Geschaeftsleitung: A.Gach/U.Wilhelm,St.Nr.:007/241/13586 FA Darmstadt
HRB-9183 Darmstadt, Ust.IdNr.:DE 202220078, WEE-Reg.-Nr.: DE39305391
Tel.+49 (0)6151-817320 / Fax:+49 (0)6151-817329, info@peak-system.com
next prev parent reply other threads:[~2012-03-02 9:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 14:53 [PATCH 0/3 v7] can/usb: Add PEAK-System PCAN USB adapters driver Stephane Grosjean
2012-02-27 14:53 ` [PATCH 1/3 v7] can/usb: PEAK-System Technik USB adapters driver core Stephane Grosjean
2012-03-01 17:22 ` Marc Kleine-Budde
2012-03-02 9:29 ` Stephane Grosjean [this message]
2012-03-02 9:31 ` Marc Kleine-Budde
2012-02-27 14:53 ` [PATCH 2/3 v7] can/usb: PEAK-System Technik PCAN-USB specific part Stephane Grosjean
2012-02-27 14:53 ` [PATCH 3/3] can/usb: PEAK-System Technik PCAN-USB Pro " Stephane Grosjean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5092EB.9000303@peak-system.com \
--to=s.grosjean@peak-system.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.