From: Amit Virdi <amit.virdi@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/7] net/designware: Fix to restore hw mac address
Date: Fri, 2 Mar 2012 16:57:40 +0530 [thread overview]
Message-ID: <4F50AEAC.5020600@st.com> (raw)
In-Reply-To: <201202291409.33186.vapier@gentoo.org>
On 3/1/2012 12:39 AM, Mike Frysinger wrote:
> On Wednesday 29 February 2012 05:37:20 Amit Virdi wrote:
>> The network controller mac resets hardware address stored in MAC_HI and
>> MAC_LO registers if mac is resetted. So, hw mac address needs to be
>> restored in case mac is explicitly resetted from driver.
>
> OK, but ...
>
>> --- a/drivers/net/designware.c
>> +++ b/drivers/net/designware.c
>>
>> + dw_write_hwaddr(dev);
>
> ... please add a comment above this line explaining why you must explicitly
> make this call
Ok, Mike. I'll send V2 with comment added.
Thanks
Amit Virdi
next prev parent reply other threads:[~2012-03-02 11:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 10:37 [U-Boot] [PATCH 0/7] net/designware: Bug fixes Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 1/7] net/designware: Fix to restore hw mac address Amit Virdi
2012-02-29 19:09 ` Mike Frysinger
2012-03-02 11:27 ` Amit Virdi [this message]
2012-02-29 10:37 ` [U-Boot] [PATCH 2/7] net/designware: Fix the max frame length size Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 3/7] net/designware: Phy address fix Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 4/7] net/designware: Consecutive writes must have delay Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 5/7] net/designware: Try configuring phy on each dw_eth_init Amit Virdi
2012-02-29 19:11 ` Mike Frysinger
2012-03-02 11:40 ` Amit Virdi
2012-03-02 18:38 ` Mike Frysinger
2012-03-05 12:18 ` Amit Virdi
2012-03-05 19:05 ` Wolfgang Denk
2012-03-06 4:21 ` Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 6/7] net/designware: Program phy registers when auto-negotiation is ON Amit Virdi
2012-02-29 10:37 ` [U-Boot] [PATCH 7/7] net/designware: Set ANAR to 0x1e1 Amit Virdi
2012-03-07 9:49 ` [U-Boot] [PATCH 0/7] net/designware: Bug fixes Amit Virdi
2012-03-07 9:55 ` Stefan Roese
2012-03-07 10:05 ` Amit Virdi
2012-03-07 12:15 ` Amit Virdi
2012-03-07 12:36 ` Wolfgang Denk
2012-03-07 16:10 ` Joe Hershberger
2012-03-08 10:55 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F50AEAC.5020600@st.com \
--to=amit.virdi@st.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.