From: Dmitry Tarnyagin <dmitry.tarnyagin@stericsson.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 21/21] cw1200: Kconfig + Makefile for the driver.
Date: Fri, 2 Mar 2012 16:45:24 +0100 [thread overview]
Message-ID: <4F50EB14.2060206@stericsson.com> (raw)
In-Reply-To: <1330678213.8542.6.camel@jlt3.sipsolutions.net>
Hi Johannes,
I fixed most of comments and cleaned up Kconfig a bit, will resubmit the
patchset soon.
>> +config CW1200_BH_DEBUG
>> + bool "Enable low-level device communication logs (DEVELOPMENT)"
>> + help
>> + Say Y if you want to enable BH logs.
>> + If unsure, say N.
> What does "BH" stand for here? In the kernel it typically stands for
> Bottom Half (or softirq) but that can't be meant? In other places in
> your code you do mean that though, it seems, so this is a bit confusing.
Well, I see it was a big mistake to call serving thread "bh" :).
Starting this project
once again I would not do it like that. But it is difficult to rename it
all around
the code now, just because the code is published already on Igloo.
> You should think about adding tracing instead.
Good point. I added it to TODO list.
Dmitry
prev parent reply other threads:[~2012-03-02 15:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <d53e019b1a0bcd29c2c367fbe5665413f2d33938-submit>
2012-03-02 1:41 ` [PATCH 00/21] cw1200: mac80211-based driver for ST-Ericsson CW1200 device Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 01/21] cw1200: cw1200.h, private driver data Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 02/21] cw1200: cw1200_plat.h, definition of the driver'ss platform data Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 03/21] cw1200: sbus.h, common device interface abstraction Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 04/21] cw1200: cw1200_sdio.c, implementation of SDIO wrapper for the driver Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 05/21] cw1200: hwio.*, device reg/mem map and low-level i/o primitives Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 06/21] cw1200: fwio.*, firmware downloading code for the cw1200 driver Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 07/21] cw1200: queue.*, implementation of TX queues of " Dmitry Tarnyagin
2012-03-02 8:33 ` Johannes Berg
2012-03-02 15:32 ` Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 08/21] cw1200: wsm.*, implementation of device high-level interface Dmitry Tarnyagin
2012-03-02 8:34 ` Johannes Berg
2012-03-02 8:41 ` Joe Perches
2012-03-02 1:41 ` [PATCH 09/21] cw1200: txrx.*, implementation of datapath Dmitry Tarnyagin
2012-05-07 12:53 ` Bob Copeland
2012-05-08 7:09 ` Dmitry Tarnyagin
2012-05-08 12:54 ` Bob Copeland
2012-03-02 1:41 ` [PATCH 10/21] cw1200: ht.h, small helper header with HT definitions Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 11/21] cw1200: bh.*, device serving thread Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 12/21] cw1200: sta.*, mac80211 STA callbacks Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 13/21] cw1200: ap.*, mac80211 AP callbacks Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 14/21] cw1200: scan.*, mac80211 hw_scan callback Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 15/21] cw1200: debug.*, implementation of the driver's debugfs Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 16/21] cw1200: itp.*, internal device test and calibration code Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 17/21] cw1200: pm.*, power management code Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 18/21] cw1200: main.c, core initialization code Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 19/21] cw1200: TODO list Dmitry Tarnyagin
2012-03-02 8:51 ` Johannes Berg
2012-03-02 1:41 ` [PATCH 20/21] cw1200: Credits Dmitry Tarnyagin
2012-03-02 1:41 ` [PATCH 21/21] cw1200: Kconfig + Makefile for the driver Dmitry Tarnyagin
2012-03-02 8:50 ` Johannes Berg
2012-03-02 15:45 ` Dmitry Tarnyagin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F50EB14.2060206@stericsson.com \
--to=dmitry.tarnyagin@stericsson.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.