Re: [PATCH 06/32] Hob: implement a self-defined notebook visual component for Hob

[Joshua Lock <josh@linux.intel.com>]

On 01/03/12 23:06, Wang, Shane wrote:
> Joshua Lock wrote on 2012-03-01:
>
>>
>>
>> On 29/02/12 06:15, Shane Wang wrote:
>>> In recipe selection page, package selection page, and build details page,
>> etc, there is a notebook component which is not gtk.Notebook in the design
>> video.
>>> We implement the visual component with a drawing area, and use it to
>> replace the old notebook in recipe selection page and package selection
>> page.
>>>
>>> Signed-off-by: Liming An<limingx.l.an@intel.com>
>>> Signed-off-by: Shane Wang<shane.wang@intel.com>
>>
>> Code style comments below.
>>
>> More importantly, have we made sure we can't use the stock notebook
>> before we've implemented our own? The commit log tells me that we aren't
>> using gtk.Notebook but doesn't tell me why?
> 1) General speaking, gtk.Notebook doesn't look like the design Belen worked out.
> 2) And we all agree Belen's design looks better, for example, there is an indicator to show how many recipes or packages are included, and how many issues happened when building? Very straightforward.
> But technically, gtk.Notebook can't implement that. As far as we know, it can't.
>
> 3) Moreover, there is an entry for "search recipes", and "search packages". How to make it horizontal to the tabs is a problem to us.
> Regarding those, we give up gtk.Notebook and use our own.

This all seems reasonable but is the sort of information I'd expect to 
see documented in the code and the commit logs. :-)

>>
>> The implemented notebook is a reasonable start but it needs a lot of
>> polish before I'd want to see it shipped.
>> i.e. the green flashed border around the selected tabs is strange, the
>> drawing looks a little jaggy, especially the orange circle (not a
>> graphics guy so I don't know the right term) and I'm pretty certain the
>> number in the circle isn't centred. Finally (for now) once I get to
>> three digits the numbers don't fit in the circle.
> I agree we also have some to improve our Notebook, say, the border and the circle.
> If there is a jaggy, we can make it a rectangle instead of circle.
> But to be frank, I don't think gtk.Notebook looks better.

That's fine, and I'm not disagreeing - I'm just trying to follow what's 
happening and by reading the logs and code as is I don't see any of the 
rationale.

Cheers,

Joshua
-- 
Joshua Lock
         Yocto Project "Johannes factotum"
         Intel Open Source Technology Centre