From: Bruce Ashfield <bruce.ashfield@windriver.com>
To: Darren Hart <darren@dvhart.com>
Cc: Yocto Project <yocto@yoctoproject.org>
Subject: Re: [PATCH 2/6] Remove boot-live cfg duplication from BSPs
Date: Fri, 2 Mar 2012 16:14:47 -0500 [thread overview]
Message-ID: <4F513847.6080909@windriver.com> (raw)
In-Reply-To: <607c67a37d0c27ba5c2c412696c023a9f3182514.1330644090.git.darren@dvhart.com>
On 12-03-01 06:59 PM, Darren Hart wrote:
> From: Darren Hart<dvhart@linux.intel.com>
>
> Several BSPs duplicated the boot-live fragment in their BSP
> specific config. Remove the duplication and add CONFIG_RD_GZIP
> and CONFIG_BLK_DEV_SR to the boot-live fragment.
Looks fine to me as well. That's a better place for the common
options.
Bruce
>
> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
> Acked-by: Tom Zanussi<tzanussi@intel.com>
> ---
> .../cfg/kernel-cache/bsp/cedartrail/cedartrail.cfg | 10 ----------
> meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg | 10 ----------
> meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg | 10 ----------
> meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg | 10 ----------
> meta/cfg/kernel-cache/bsp/fri2/fri2.cfg | 10 ----------
> meta/cfg/kernel-cache/bsp/sys940x/sys940x.cfg | 5 -----
> meta/cfg/kernel-cache/cfg/boot-live.cfg | 3 +++
> 7 files changed, 3 insertions(+), 55 deletions(-)
>
> diff --git a/meta/cfg/kernel-cache/bsp/cedartrail/cedartrail.cfg b/meta/cfg/kernel-cache/bsp/cedartrail/cedartrail.cfg
> index 1cc14b1..32cd9e5 100755
> --- a/meta/cfg/kernel-cache/bsp/cedartrail/cedartrail.cfg
> +++ b/meta/cfg/kernel-cache/bsp/cedartrail/cedartrail.cfg
> @@ -46,13 +46,3 @@ CONFIG_MODULES=y
> CONFIG_SHMEM=y
> CONFIG_TMPFS=y
> CONFIG_PACKET=y
> -
> -# Needed for booting (and using) USB memory sticks
> -CONFIG_BLK_DEV_LOOP=y
> -CONFIG_NLS_CODEPAGE_437=y
> -CONFIG_NLS_ISO8859_1=y
> -
> -CONFIG_RD_GZIP=y
> -
> -# Needed for booting (and using) CD images
> -CONFIG_BLK_DEV_SR=y
> diff --git a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
> index e93c0b8..b101419 100644
> --- a/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
> +++ b/meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg
> @@ -42,13 +42,3 @@ CONFIG_MODULES=y
> CONFIG_SHMEM=y
> CONFIG_TMPFS=y
> CONFIG_PACKET=y
> -
> -# Needed for booting (and using) USB memory sticks
> -CONFIG_BLK_DEV_LOOP=y
> -CONFIG_NLS_CODEPAGE_437=y
> -CONFIG_NLS_ISO8859_1=y
> -
> -CONFIG_RD_GZIP=y
> -
> -# Needed for booting (and using) CD images
> -CONFIG_BLK_DEV_SR=y
> diff --git a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg
> index b9704c5..b1e72bd 100644
> --- a/meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg
> +++ b/meta/cfg/kernel-cache/bsp/emenlow/emenlow.cfg
> @@ -40,13 +40,3 @@ CONFIG_MODULES=y
> CONFIG_SHMEM=y
> CONFIG_TMPFS=y
> CONFIG_PACKET=y
> -
> -# Needed for booting (and using) USB memory sticks
> -CONFIG_BLK_DEV_LOOP=y
> -CONFIG_NLS_CODEPAGE_437=y
> -CONFIG_NLS_ISO8859_1=y
> -
> -CONFIG_RD_GZIP=y
> -
> -# Needed for booting (and using) CD images
> -CONFIG_BLK_DEV_SR=y
> diff --git a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg
> index e93c0b8..b101419 100644
> --- a/meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg
> +++ b/meta/cfg/kernel-cache/bsp/fishriver/fishriver.cfg
> @@ -42,13 +42,3 @@ CONFIG_MODULES=y
> CONFIG_SHMEM=y
> CONFIG_TMPFS=y
> CONFIG_PACKET=y
> -
> -# Needed for booting (and using) USB memory sticks
> -CONFIG_BLK_DEV_LOOP=y
> -CONFIG_NLS_CODEPAGE_437=y
> -CONFIG_NLS_ISO8859_1=y
> -
> -CONFIG_RD_GZIP=y
> -
> -# Needed for booting (and using) CD images
> -CONFIG_BLK_DEV_SR=y
> diff --git a/meta/cfg/kernel-cache/bsp/fri2/fri2.cfg b/meta/cfg/kernel-cache/bsp/fri2/fri2.cfg
> index e93c0b8..b101419 100644
> --- a/meta/cfg/kernel-cache/bsp/fri2/fri2.cfg
> +++ b/meta/cfg/kernel-cache/bsp/fri2/fri2.cfg
> @@ -42,13 +42,3 @@ CONFIG_MODULES=y
> CONFIG_SHMEM=y
> CONFIG_TMPFS=y
> CONFIG_PACKET=y
> -
> -# Needed for booting (and using) USB memory sticks
> -CONFIG_BLK_DEV_LOOP=y
> -CONFIG_NLS_CODEPAGE_437=y
> -CONFIG_NLS_ISO8859_1=y
> -
> -CONFIG_RD_GZIP=y
> -
> -# Needed for booting (and using) CD images
> -CONFIG_BLK_DEV_SR=y
> diff --git a/meta/cfg/kernel-cache/bsp/sys940x/sys940x.cfg b/meta/cfg/kernel-cache/bsp/sys940x/sys940x.cfg
> index 3d45fe8..b101419 100644
> --- a/meta/cfg/kernel-cache/bsp/sys940x/sys940x.cfg
> +++ b/meta/cfg/kernel-cache/bsp/sys940x/sys940x.cfg
> @@ -42,8 +42,3 @@ CONFIG_MODULES=y
> CONFIG_SHMEM=y
> CONFIG_TMPFS=y
> CONFIG_PACKET=y
> -
> -CONFIG_RD_GZIP=y
> -
> -# Needed for booting (and using) CD images
> -CONFIG_BLK_DEV_SR=y
> diff --git a/meta/cfg/kernel-cache/cfg/boot-live.cfg b/meta/cfg/kernel-cache/cfg/boot-live.cfg
> index 8ff7674..a102052 100644
> --- a/meta/cfg/kernel-cache/cfg/boot-live.cfg
> +++ b/meta/cfg/kernel-cache/cfg/boot-live.cfg
> @@ -2,5 +2,8 @@ CONFIG_BLK_DEV_LOOP=y
> CONFIG_NLS_CODEPAGE_437=y
> CONFIG_NLS_ISO8859_1=y
> CONFIG_VFAT_FS=y
> +CONFIG_RD_GZIP=y
> +# Needed for booting (and using) CD images
> CONFIG_BLK_DEV_IDECD=y
> CONFIG_ISO9660_FS=y
> +CONFIG_BLK_DEV_SR=y
next prev parent reply other threads:[~2012-03-02 21:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 23:59 [PATCH 0/6][linux-yocto-3.2] Meta update for sys940x, bootlive, and FRI2 Darren Hart
2012-03-01 23:59 ` [PATCH 1/6] meta: sys940x BSP meta data Darren Hart
2012-03-01 23:59 ` [PATCH 2/6] Remove boot-live cfg duplication from BSPs Darren Hart
2012-03-02 21:14 ` Bruce Ashfield [this message]
2012-03-01 23:59 ` [PATCH 3/6] fri2: Drop 8250 from the fri2 scc Darren Hart
2012-03-01 23:59 ` [PATCH 4/6] eg20t: Enable serial console for the pch_uart Darren Hart
2012-03-02 21:16 ` Bruce Ashfield
2012-03-02 21:40 ` Darren Hart
2012-03-04 4:00 ` Bruce Ashfield
2012-03-01 23:59 ` [PATCH 5/6] fri2: Add SMP and EFI support Darren Hart
2012-03-02 21:16 ` Bruce Ashfield
2012-03-01 23:59 ` [PATCH 6/6] fri2: Move non-hardware optional features out of fri2.scc Darren Hart
2012-03-02 21:17 ` Bruce Ashfield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F513847.6080909@windriver.com \
--to=bruce.ashfield@windriver.com \
--cc=darren@dvhart.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.