From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Cousson, Benoit" Subject: Re: [PATCH] devicetree: Add empty of_platform_populate() for !CONFIG_OF_ADDRESS (sparc) Date: Fri, 2 Mar 2012 22:20:16 +0100 Message-ID: <4F513990.1030401@ti.com> References: <1330121218-10442-1-git-send-email-grant.likely@secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1330121218-10442-1-git-send-email-grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org To: Grant Likely Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Samuel Ortiz List-Id: devicetree@vger.kernel.org Hi Grant, In fact this patch is not working for build without CONFIG_OF like x86. On 2/24/2012 11:06 PM, Grant Likely wrote: > --- a/include/linux/of_platform.h > +++ b/include/linux/of_platform.h > @@ -81,7 +81,7 @@ extern struct platform_device *of_device_alloc(struct device_node *np, > struct device *parent); > extern struct platform_device *of_find_device_by_node(struct device_node *np); > > -#if !defined(CONFIG_SPARC) /* SPARC has its own device registration method */ > +#ifdef CONFIG_OF_ADDRESS /* device reg helpers depend on OF_ADDRESS */ > /* Platform devices and busses creation */ > extern struct platform_device *of_platform_device_create(struct device_node *np, > const char *bus_id, > @@ -94,7 +94,15 @@ extern int of_platform_populate(struct device_node *root, > const struct of_device_id *matches, > const struct of_dev_auxdata *lookup, > struct device *parent); > -#endif /* !CONFIG_SPARC */ > +#else > +static inline int of_platform_populate(struct device_node *root, > + const struct of_device_id *matches, > + const struct of_dev_auxdata *lookup, > + struct device *parent) > +{ > + return -ENODEV; > +} > +#endif /* !CONFIG_OF_ADDRESS */ > > #endif /* CONFIG_OF_DEVICE */ Because if CONFIG_OF_DEVICE is not defined, then the stub for of_platform_populate will not be defined either. It should exist for any config without CONFIG_OF. Building twl4030 for x86 is actually broken. Regards, Benoit From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758539Ab2CBVUa (ORCPT ); Fri, 2 Mar 2012 16:20:30 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:38341 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758401Ab2CBVU1 (ORCPT ); Fri, 2 Mar 2012 16:20:27 -0500 Message-ID: <4F513990.1030401@ti.com> Date: Fri, 2 Mar 2012 22:20:16 +0100 From: "Cousson, Benoit" Organization: Texas Instruments User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: Grant Likely CC: , , Samuel Ortiz Subject: Re: [PATCH] devicetree: Add empty of_platform_populate() for !CONFIG_OF_ADDRESS (sparc) References: <1330121218-10442-1-git-send-email-grant.likely@secretlab.ca> In-Reply-To: <1330121218-10442-1-git-send-email-grant.likely@secretlab.ca> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Grant, In fact this patch is not working for build without CONFIG_OF like x86. On 2/24/2012 11:06 PM, Grant Likely wrote: > --- a/include/linux/of_platform.h > +++ b/include/linux/of_platform.h > @@ -81,7 +81,7 @@ extern struct platform_device *of_device_alloc(struct device_node *np, > struct device *parent); > extern struct platform_device *of_find_device_by_node(struct device_node *np); > > -#if !defined(CONFIG_SPARC) /* SPARC has its own device registration method */ > +#ifdef CONFIG_OF_ADDRESS /* device reg helpers depend on OF_ADDRESS */ > /* Platform devices and busses creation */ > extern struct platform_device *of_platform_device_create(struct device_node *np, > const char *bus_id, > @@ -94,7 +94,15 @@ extern int of_platform_populate(struct device_node *root, > const struct of_device_id *matches, > const struct of_dev_auxdata *lookup, > struct device *parent); > -#endif /* !CONFIG_SPARC */ > +#else > +static inline int of_platform_populate(struct device_node *root, > + const struct of_device_id *matches, > + const struct of_dev_auxdata *lookup, > + struct device *parent) > +{ > + return -ENODEV; > +} > +#endif /* !CONFIG_OF_ADDRESS */ > > #endif /* CONFIG_OF_DEVICE */ Because if CONFIG_OF_DEVICE is not defined, then the stub for of_platform_populate will not be defined either. It should exist for any config without CONFIG_OF. Building twl4030 for x86 is actually broken. Regards, Benoit